lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[usb netdev] asix: fix regression

Browse Source 
51bf2976b5 caused a regression in the asix
usbnet driver. usb_control_msg returns the number of bytes read on
success, not 0. Tested with NETGEAR FA120.

Signed-off-by: Russ Dill <Russ.Dill@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
This commit is contained in:
Russ Dill
2008-01-09 21:32:07 -07:00
committed by Jeff Garzik
parent cadf1855e9
commit 94d433630a
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/usb/asix.c
View File

@@ -202,10 +202,10 @@ static int asix_read_cmd(struct usbnet *dev, u8 cmd, u16 value, u16 index,
buf, buf,
size, size,
USB_CTRL_GET_TIMEOUT); USB_CTRL_GET_TIMEOUT);
if (err >= 0 && err < size) if (err == size)
err = -EINVAL;
if (!err)
memcpy(data, buf, size); memcpy(data, buf, size);
else if (err >= 0)
err = -EINVAL;
kfree(buf); kfree(buf);
out: out: