lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[PATCH] i386: handle a negative return value

Browse Source 
The Coverity checker noted that bad things might happen if
find_isa_irq_apic() returned -1.

[akpm@osdl.org: add debugging checks]
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Andi Kleen <ak@suse.de>
Cc: Andi Kleen <ak@suse.de>
Acked-by: Ingo Molnar <mingo@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
This commit is contained in:
Adrian Bunk
2006-12-07 02:14:11 +01:00
committed by Andi Kleen
parent e1cccf48b1
commit 956fb53197
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
arch/i386/kernel/io_apic.c
View File

@@ -2179,9 +2179,15 @@ static inline void unlock_ExtINT_logic(void)
unsigned char save_control, save_freq_select; unsigned char save_control, save_freq_select;
pin = find_isa_irq_pin(8, mp_INT); pin = find_isa_irq_pin(8, mp_INT);
apic = find_isa_irq_apic(8, mp_INT); if (pin == -1) {
if (pin == -1) WARN_ON_ONCE(1);
return; return;
}
apic = find_isa_irq_apic(8, mp_INT);
if (apic == -1) {
WARN_ON_ONCE(1);
return;
}
entry0 = ioapic_read_entry(apic, pin); entry0 = ioapic_read_entry(apic, pin);
clear_IO_APIC_pin(apic, pin); clear_IO_APIC_pin(apic, pin);