lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[media] gspca: Fix a warning for using len before filling it

Browse Source 
The check for status errors is now before the check for len. That's
ok. However, the error printk's for the status error prints the URB
length. This generates this error:

drivers/media/video/gspca/gspca.c: In function ‘fill_frame’:
drivers/media/video/gspca/gspca.c:305:9: warning: ‘len’ may be used uninitialized in this function

The fix is as simple as moving the len init to happen before the checks.

Cc: Jean-François Moine <moinejf@free.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Mauro Carvalho Chehab 2010-12-27 12:00:03 -03:00
parent 2e94b53c55
commit 95f18be2e4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/media/video/gspca/gspca.c
View File

@ -318,6 +318,7 @@ static void fill_frame(struct gspca_dev *gspca_dev,
} }
pkt_scan = gspca_dev->sd_desc->pkt_scan; pkt_scan = gspca_dev->sd_desc->pkt_scan;
for (i = 0; i < urb->number_of_packets; i++) { for (i = 0; i < urb->number_of_packets; i++) {
len = urb->iso_frame_desc[i].actual_length;
/* check the packet status and length */ /* check the packet status and length */
st = urb->iso_frame_desc[i].status; st = urb->iso_frame_desc[i].status;
@ -327,7 +328,6 @@ static void fill_frame(struct gspca_dev *gspca_dev,
gspca_dev->last_packet_type = DISCARD_PACKET; gspca_dev->last_packet_type = DISCARD_PACKET;
continue; continue;
} }
len = urb->iso_frame_desc[i].actual_length;
if (len == 0) { if (len == 0) {
if (gspca_dev->empty_packet == 0) if (gspca_dev->empty_packet == 0)
gspca_dev->empty_packet = 1; gspca_dev->empty_packet = 1;