lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ide: make "paranoia" ->handler check in ide_intr() more strict

Browse Source 
If ->handler is set while it shouldn't be it indicates deep problems
so BUG_ON()-ning and preventing further damage is much more appropriate
than merely printing an error message.

Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
This commit is contained in:
Bartlomiej Zolnierkiewicz
2009-01-06 17:20:58 +01:00
parent d6251d4488
commit 9600dcf134
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/ide/ide-io.c
View File

@@ -1159,12 +1159,9 @@ irqreturn_t ide_intr (int irq, void *dev_id)
* won't allow another of the same (on any CPU) until we return. * won't allow another of the same (on any CPU) until we return.
*/ */
if (startstop == ide_stopped) { if (startstop == ide_stopped) {
if (hwif->handler == NULL) { /* paranoia */ BUG_ON(hwif->handler);
ide_unlock_port(hwif); ide_unlock_port(hwif);
plug_device = 1; plug_device = 1;
} else
printk(KERN_ERR "%s: %s: huh? expected NULL handler "
"on exit\n", __func__, drive->name);
} }
out_handled: out_handled:
irq_ret = IRQ_HANDLED; irq_ret = IRQ_HANDLED;