lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

vfio: fix crash on rmmod

Browse Source 
devtmpfs_delete_node() calls devnode() callback with mode==NULL but
vfio still tries to write there.

The patch fixes this.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
This commit is contained in:
Alexey Kardashevskiy
2013-06-05 08:54:16 -06:00
committed by Alex Williamson
parent d683b96b07
commit 9a6aa279d3
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/vfio/vfio.c
View File

@@ -1360,7 +1360,7 @@ static const struct file_operations vfio_device_fops = {
*/ */
static char *vfio_devnode(struct device *dev, umode_t *mode) static char *vfio_devnode(struct device *dev, umode_t *mode)
{ {
if (MINOR(dev->devt) == 0) if (mode && (MINOR(dev->devt) == 0))
*mode = S_IRUGO | S_IWUGO; *mode = S_IRUGO | S_IWUGO;
return kasprintf(GFP_KERNEL, "vfio/%s", dev_name(dev)); return kasprintf(GFP_KERNEL, "vfio/%s", dev_name(dev));