lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

blktrace: perform cleanup after setup error

Browse Source 
Currently even if BLKTRACESETUP ioctl has failed user must call
BLKTRACETEARDOWN to be shure what all staff was cleaned, which
is contr-intuitive.
Let's setup ioctl make necessery cleanup by it self.

Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
This commit is contained in:
Dmitry Monakhov
2010-02-27 20:35:13 +03:00
committed by Jens Axboe
parent 9f7cdbc33f
commit 9a8c28c831
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
kernel/trace/blktrace.c
View File

@@ -540,9 +540,10 @@ int blk_trace_setup(struct request_queue *q, char *name, dev_t dev,
if (ret) if (ret)
return ret; return ret;
if (copy_to_user(arg, &buts, sizeof(buts))) if (copy_to_user(arg, &buts, sizeof(buts))) {
blk_trace_remove(q);
return -EFAULT; return -EFAULT;
}
return 0; return 0;
} }
EXPORT_SYMBOL_GPL(blk_trace_setup); EXPORT_SYMBOL_GPL(blk_trace_setup);