Merge git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6
* git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-misc-2.6: (200 commits) [SCSI] usbstorage: use last_sector_bug flag universally [SCSI] libsas: abstract STP task status into a function [SCSI] ultrastor: clean up inline asm warnings [SCSI] aic7xxx: fix firmware build [SCSI] aacraid: fib context lock for management ioctls [SCSI] ch: remove forward declarations [SCSI] ch: fix device minor number management bug [SCSI] ch: handle class_device_create failure properly [SCSI] NCR5380: fix section mismatch [SCSI] sg: fix /proc/scsi/sg/devices when no SCSI devices [SCSI] IB/iSER: add logical unit reset support [SCSI] don't use __GFP_DMA for sense buffers if not required [SCSI] use dynamically allocated sense buffer [SCSI] scsi.h: add macro for enclosure bit of inquiry data [SCSI] sd: add fix for devices with last sector access problems [SCSI] fix pcmcia compile problem [SCSI] aacraid: add Voodoo Lite class of cards. [SCSI] aacraid: add new driver features flags [SCSI] qla2xxx: Update version number to 8.02.00-k7. [SCSI] qla2xxx: Issue correct MBC_INITIALIZE_FIRMWARE command. ...
This commit is contained in:
@@ -320,9 +320,14 @@ attribute_container_add_attrs(struct class_device *classdev)
|
||||
struct class_device_attribute **attrs = cont->attrs;
|
||||
int i, error;
|
||||
|
||||
if (!attrs)
|
||||
BUG_ON(attrs && cont->grp);
|
||||
|
||||
if (!attrs && !cont->grp)
|
||||
return 0;
|
||||
|
||||
if (cont->grp)
|
||||
return sysfs_create_group(&classdev->kobj, cont->grp);
|
||||
|
||||
for (i = 0; attrs[i]; i++) {
|
||||
error = class_device_create_file(classdev, attrs[i]);
|
||||
if (error)
|
||||
@@ -378,9 +383,14 @@ attribute_container_remove_attrs(struct class_device *classdev)
|
||||
struct class_device_attribute **attrs = cont->attrs;
|
||||
int i;
|
||||
|
||||
if (!attrs)
|
||||
if (!attrs && !cont->grp)
|
||||
return;
|
||||
|
||||
if (cont->grp) {
|
||||
sysfs_remove_group(&classdev->kobj, cont->grp);
|
||||
return ;
|
||||
}
|
||||
|
||||
for (i = 0; attrs[i]; i++)
|
||||
class_device_remove_file(classdev, attrs[i]);
|
||||
}
|
||||
|
Reference in New Issue
Block a user