lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

slip: Drag kicking and screaming into coding style compliance

Browse Source 
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
This commit is contained in:
Alan Cox
2007-11-19 15:03:38 +00:00
committed by David S. Miller
parent a35f5de776
commit 9ce6cf2553
1 changed files with 178 additions and 189 deletions
Download Patch File Download Diff File Expand all files Collapse all files

235
drivers/net/slip.c
View File

@@ -11,9 +11,11 @@
* Fixes: * Fixes:
* Alan Cox : Sanity checks and avoid tx overruns. * Alan Cox : Sanity checks and avoid tx overruns.
* Has a new sl->mtu field. * Has a new sl->mtu field.
* Alan Cox : Found cause of overrun. ifconfig sl0 mtu upwards. * Alan Cox : Found cause of overrun. ifconfig sl0
* Driver now spots this and grows/shrinks its buffers(hack!). * mtu upwards. Driver now spots this
* Memory leak if you run out of memory setting up a slip driver fixed. * and grows/shrinks its buffers(hack!).
* Memory leak if you run out of memory
* setting up a slip driver fixed.
* Matt Dillon : Printable slip (borrowed from NET2E) * Matt Dillon : Printable slip (borrowed from NET2E)
* Pauline Middelink : Slip driver fixes. * Pauline Middelink : Slip driver fixes.
* Alan Cox : Honours the old SL_COMPRESSED flag * Alan Cox : Honours the old SL_COMPRESSED flag
@@ -29,7 +31,8 @@
* buffering from 4096 to 256 bytes. * buffering from 4096 to 256 bytes.
* Improving SLIP response time. * Improving SLIP response time.
* CONFIG_SLIP_MODE_SLIP6. * CONFIG_SLIP_MODE_SLIP6.
* ifconfig sl? up & down now works correctly. * ifconfig sl? up & down now works
* correctly.
* Modularization. * Modularization.
* Alan Cox : Oops - fix AX.25 buffer lengths * Alan Cox : Oops - fix AX.25 buffer lengths
* Dmitry Gorodchanin : Even more cleanups. Preserve CSLIP * Dmitry Gorodchanin : Even more cleanups. Preserve CSLIP
@@ -43,15 +46,18 @@
* device entries, just reg./unreg. them * device entries, just reg./unreg. them
* as they are needed. We kfree() them * as they are needed. We kfree() them
* at module cleanup. * at module cleanup.
* With MODULE-loading ``insmod'', user can * With MODULE-loading ``insmod'', user
* issue parameter: slip_maxdev=1024 * can issue parameter: slip_maxdev=1024
* (Or how much he/she wants.. Default is 256) * (Or how much he/she wants.. Default
* * Stanislav Voronyi : Slip line checking, with ideas taken * is 256)
* from multislip BSDI driver which was written * Stanislav Voronyi : Slip line checking, with ideas taken
* by Igor Chechik, RELCOM Corp. Only algorithms * from multislip BSDI driver which was
* have been ported to Linux SLIP driver. * written by Igor Chechik, RELCOM Corp.
* Only algorithms have been ported to
* Linux SLIP driver.
* Vitaly E. Lavrov : Sane behaviour on tty hangup. * Vitaly E. Lavrov : Sane behaviour on tty hangup.
* Alexey Kuznetsov : Cleanup interfaces to tty&netdevice modules. * Alexey Kuznetsov : Cleanup interfaces to tty & netdevice
* modules.
*/ */
#define SL_CHECK_TRANSMIT #define SL_CHECK_TRANSMIT
@@ -117,8 +123,7 @@ static int sl_ioctl(struct net_device *dev,struct ifreq *rq,int cmd);
Allocate channel buffers. Allocate channel buffers.
*/ */
static int static int sl_alloc_bufs(struct slip *sl, int mtu)
sl_alloc_bufs(struct slip *sl, int mtu)
{ {
int err = -ENOBUFS; int err = -ENOBUFS;
unsigned long len; unsigned long len;
@@ -195,8 +200,7 @@ err_exit:
} }
/* Free a SLIP channel buffers. */ /* Free a SLIP channel buffers. */
static void static void sl_free_bufs(struct slip *sl)
sl_free_bufs(struct slip *sl)
{ {
/* Free all SLIP frame buffers. */ /* Free all SLIP frame buffers. */
kfree(xchg(&sl->rbuff, NULL)); kfree(xchg(&sl->rbuff, NULL));
@@ -248,7 +252,6 @@ static int sl_realloc_bufs(struct slip *sl, int mtu)
} }
goto done; goto done;
} }
spin_lock_bh(&sl->lock); spin_lock_bh(&sl->lock);
err = -ENODEV; err = -ENODEV;
@@ -298,23 +301,20 @@ done:
/* Set the "sending" flag. This must be atomic hence the set_bit. */ /* Set the "sending" flag. This must be atomic hence the set_bit. */
static inline void static inline void sl_lock(struct slip *sl)
sl_lock(struct slip *sl)
{ {
netif_stop_queue(sl->dev); netif_stop_queue(sl->dev);
} }
/* Clear the "sending" flag. This must be atomic, hence the ASM. */ /* Clear the "sending" flag. This must be atomic, hence the ASM. */
static inline void static inline void sl_unlock(struct slip *sl)
sl_unlock(struct slip *sl)
{ {
netif_wake_queue(sl->dev); netif_wake_queue(sl->dev);
} }
/* Send one completely decapsulated IP datagram to the IP layer. */ /* Send one completely decapsulated IP datagram to the IP layer. */
static void static void sl_bump(struct slip *sl)
sl_bump(struct slip *sl)
{ {
struct sk_buff *skb; struct sk_buff *skb;
int count; int count;
@@ -322,22 +322,22 @@ sl_bump(struct slip *sl)
count = sl->rcount; count = sl->rcount;
#ifdef SL_INCLUDE_CSLIP #ifdef SL_INCLUDE_CSLIP
if (sl->mode & (SL_MODE_ADAPTIVE | SL_MODE_CSLIP)) { if (sl->mode & (SL_MODE_ADAPTIVE | SL_MODE_CSLIP)) {
unsigned char c; unsigned char c = sl->rbuff[0];
if ((c = sl->rbuff[0]) & SL_TYPE_COMPRESSED_TCP) { if (c & SL_TYPE_COMPRESSED_TCP) {
/* ignore compressed packets when CSLIP is off */ /* ignore compressed packets when CSLIP is off */
if (!(sl->mode & SL_MODE_CSLIP)) { if (!(sl->mode & SL_MODE_CSLIP)) {
printk(KERN_WARNING "%s: compressed packet ignored\n", sl->dev->name); printk(KERN_WARNING "%s: compressed packet ignored\n", sl->dev->name);
return; return;
} }
/* make sure we've reserved enough space for uncompress to use */ /* make sure we've reserved enough space for uncompress
to use */
if (count + 80 > sl->buffsize) { if (count + 80 > sl->buffsize) {
sl->rx_over_errors++; sl->rx_over_errors++;
return; return;
} }
count = slhc_uncompress(sl->slcomp, sl->rbuff, count); count = slhc_uncompress(sl->slcomp, sl->rbuff, count);
if (count <= 0) { if (count <= 0)
return; return;
}
} else if (c >= SL_TYPE_UNCOMPRESSED_TCP) { } else if (c >= SL_TYPE_UNCOMPRESSED_TCP) {
if (!(sl->mode & SL_MODE_CSLIP)) { if (!(sl->mode & SL_MODE_CSLIP)) {
/* turn on header compression */ /* turn on header compression */
@@ -346,11 +346,10 @@ sl_bump(struct slip *sl)
printk(KERN_INFO "%s: header compression turned on\n", sl->dev->name); printk(KERN_INFO "%s: header compression turned on\n", sl->dev->name);
} }
sl->rbuff[0] &= 0x4f; sl->rbuff[0] &= 0x4f;
if (slhc_remember(sl->slcomp, sl->rbuff, count) <= 0) { if (slhc_remember(sl->slcomp, sl->rbuff, count) <= 0)
return; return;
} }
} }
}
#endif /* SL_INCLUDE_CSLIP */ #endif /* SL_INCLUDE_CSLIP */
sl->rx_bytes += count; sl->rx_bytes += count;
@@ -371,8 +370,7 @@ sl_bump(struct slip *sl)
} }
/* Encapsulate one IP datagram and stuff into a TTY queue. */ /* Encapsulate one IP datagram and stuff into a TTY queue. */
static void static void sl_encaps(struct slip *sl, unsigned char *icp, int len)
sl_encaps(struct slip *sl, unsigned char *icp, int len)
{ {
unsigned char *p; unsigned char *p;
int actual, count; int actual, count;
@@ -386,9 +384,8 @@ sl_encaps(struct slip *sl, unsigned char *icp, int len)
p = icp; p = icp;
#ifdef SL_INCLUDE_CSLIP #ifdef SL_INCLUDE_CSLIP
if (sl->mode & SL_MODE_CSLIP) { if (sl->mode & SL_MODE_CSLIP)
len = slhc_compress(sl->slcomp, p, len, sl->cbuff, &p, 1); len = slhc_compress(sl->slcomp, p, len, sl->cbuff, &p, 1);
}
#endif #endif
#ifdef CONFIG_SLIP_MODE_SLIP6 #ifdef CONFIG_SLIP_MODE_SLIP6
if (sl->mode & SL_MODE_SLIP6) if (sl->mode & SL_MODE_SLIP6)
@@ -425,12 +422,12 @@ sl_encaps(struct slip *sl, unsigned char *icp, int len)
static void slip_write_wakeup(struct tty_struct *tty) static void slip_write_wakeup(struct tty_struct *tty)
{ {
int actual; int actual;
struct slip *sl = (struct slip *) tty->disc_data; struct slip *sl = tty->disc_data;
/* First make sure we're connected. */ /* First make sure we're connected. */
if (!sl || sl->magic != SLIP_MAGIC || !netif_running(sl->dev)) { if (!sl || sl->magic != SLIP_MAGIC || !netif_running(sl->dev))
return; return;
}
if (sl->xleft <= 0) { if (sl->xleft <= 0) {
/* Now serial buffer is almost free & we can start /* Now serial buffer is almost free & we can start
* transmission of another packet */ * transmission of another packet */
@@ -463,7 +460,8 @@ static void sl_tx_timeout(struct net_device *dev)
/* 20 sec timeout not reached */ /* 20 sec timeout not reached */
goto out; goto out;
} }
printk(KERN_WARNING "%s: transmit timed out, %s?\n", dev->name, printk(KERN_WARNING "%s: transmit timed out, %s?\n",
dev->name,
(sl->tty->driver->chars_in_buffer(sl->tty) || sl->xleft) ? (sl->tty->driver->chars_in_buffer(sl->tty) || sl->xleft) ?
"bad line quality" : "driver error"); "bad line quality" : "driver error");
sl->xleft = 0; sl->xleft = 0;
@@ -471,7 +469,6 @@ static void sl_tx_timeout(struct net_device *dev)
sl_unlock(sl); sl_unlock(sl);
#endif #endif
} }
out: out:
spin_unlock(&sl->lock); spin_unlock(&sl->lock);
} }
@@ -657,20 +654,19 @@ static void sl_setup(struct net_device *dev)
* in parallel * in parallel
*/ */
static void slip_receive_buf(struct tty_struct *tty, const unsigned char *cp, char *fp, int count) static void slip_receive_buf(struct tty_struct *tty, const unsigned char *cp,
char *fp, int count)
{ {
struct slip *sl = (struct slip *) tty->disc_data; struct slip *sl = tty->disc_data;
if (!sl || sl->magic != SLIP_MAGIC || if (!sl || sl->magic != SLIP_MAGIC || !netif_running(sl->dev))
!netif_running(sl->dev))
return; return;
/* Read the characters out of the buffer */ /* Read the characters out of the buffer */
while (count--) { while (count--) {
if (fp && *fp++) { if (fp && *fp++) {
if (!test_and_set_bit(SLF_ERROR, &sl->flags)) { if (!test_and_set_bit(SLF_ERROR, &sl->flags))
sl->rx_errors++; sl->rx_errors++;
}
cp++; cp++;
continue; continue;
} }
@@ -688,7 +684,6 @@ static void slip_receive_buf(struct tty_struct *tty, const unsigned char *cp, ch
************************************/ ************************************/
/* Collect hanged up channels */ /* Collect hanged up channels */
static void sl_sync(void) static void sl_sync(void)
{ {
int i; int i;
@@ -696,7 +691,8 @@ static void sl_sync(void)
struct slip *sl; struct slip *sl;
for (i = 0; i < slip_maxdev; i++) { for (i = 0; i < slip_maxdev; i++) {
if ((dev = slip_devs[i]) == NULL) dev = slip_devs[i];
if (dev == NULL)
break; break;
sl = netdev_priv(dev); sl = netdev_priv(dev);
@@ -709,8 +705,7 @@ static void sl_sync(void)
/* Find a free SLIP channel, and link in this `tty' line. */ /* Find a free SLIP channel, and link in this `tty' line. */
static struct slip * static struct slip *sl_alloc(dev_t line)
sl_alloc(dev_t line)
{ {
int i; int i;
int sel = -1; int sel = -1;
@@ -805,7 +800,8 @@ sl_alloc(dev_t line)
spin_lock_init(&sl->lock); spin_lock_init(&sl->lock);
sl->mode = SL_MODE_DEFAULT; sl->mode = SL_MODE_DEFAULT;
#ifdef CONFIG_SLIP_SMART #ifdef CONFIG_SLIP_SMART
init_timer(&sl->keepalive_timer); /* initialize timer_list struct */ /* initialize timer_list struct */
init_timer(&sl->keepalive_timer);
sl->keepalive_timer.data = (unsigned long)sl; sl->keepalive_timer.data = (unsigned long)sl;
sl->keepalive_timer.function = sl_keepalive; sl->keepalive_timer.function = sl_keepalive;
init_timer(&sl->outfill_timer); init_timer(&sl->outfill_timer);
@@ -813,7 +809,6 @@ sl_alloc(dev_t line)
sl->outfill_timer.function = sl_outfill; sl->outfill_timer.function = sl_outfill;
#endif #endif
slip_devs[i] = dev; slip_devs[i] = dev;
return sl; return sl;
} }
@@ -844,7 +839,7 @@ static int slip_open(struct tty_struct *tty)
/* Collect hanged up channels. */ /* Collect hanged up channels. */
sl_sync(); sl_sync();
sl = (struct slip *) tty->disc_data; sl = tty->disc_data;
err = -EEXIST; err = -EEXIST;
/* First make sure we're not already connected. */ /* First make sure we're not already connected. */
@@ -853,7 +848,8 @@ static int slip_open(struct tty_struct *tty)
/* OK. Find a free SLIP channel to use. */ /* OK. Find a free SLIP channel to use. */
err = -ENFILE; err = -ENFILE;
if ((sl = sl_alloc(tty_devnum(tty))) == NULL) sl = sl_alloc(tty_devnum(tty));
if (sl == NULL)
goto err_exit; goto err_exit;
sl->tty = tty; sl->tty = tty;
@@ -863,12 +859,14 @@ static int slip_open(struct tty_struct *tty)
if (!test_bit(SLF_INUSE, &sl->flags)) { if (!test_bit(SLF_INUSE, &sl->flags)) {
/* Perform the low-level SLIP initialization. */ /* Perform the low-level SLIP initialization. */
if ((err = sl_alloc_bufs(sl, SL_MTU)) != 0) err = sl_alloc_bufs(sl, SL_MTU);
if (err)
goto err_free_chan; goto err_free_chan;
set_bit(SLF_INUSE, &sl->flags); set_bit(SLF_INUSE, &sl->flags);
if ((err = register_netdevice(sl->dev))) err = register_netdevice(sl->dev);
if (err)
goto err_free_bufs; goto err_free_bufs;
} }
@@ -928,10 +926,9 @@ err_exit:
* This means flushing out any pending queues, and then returning. This * This means flushing out any pending queues, and then returning. This
* call is serialized against other ldisc functions. * call is serialized against other ldisc functions.
*/ */
static void static void slip_close(struct tty_struct *tty)
slip_close(struct tty_struct *tty)
{ {
struct slip *sl = (struct slip *) tty->disc_data; struct slip *sl = tty->disc_data;
/* First make sure we're connected. */ /* First make sure we're connected. */
if (!sl || sl->magic != SLIP_MAGIC || sl->tty != tty) if (!sl || sl->magic != SLIP_MAGIC || sl->tty != tty)
@@ -955,8 +952,7 @@ slip_close(struct tty_struct *tty)
* STANDARD SLIP ENCAPSULATION * * STANDARD SLIP ENCAPSULATION *
************************************************************************/ ************************************************************************/
static int static int slip_esc(unsigned char *s, unsigned char *d, int len)
slip_esc(unsigned char *s, unsigned char *d, int len)
{ {
unsigned char *ptr = d; unsigned char *ptr = d;
unsigned char c; unsigned char c;
@@ -1004,9 +1000,9 @@ static void slip_unesc(struct slip *sl, unsigned char s)
clear_bit(SLF_KEEPTEST, &sl->flags); clear_bit(SLF_KEEPTEST, &sl->flags);
#endif #endif
if (!test_and_clear_bit(SLF_ERROR, &sl->flags) && (sl->rcount > 2)) { if (!test_and_clear_bit(SLF_ERROR, &sl->flags)
&& (sl->rcount > 2))
sl_bump(sl); sl_bump(sl);
}
clear_bit(SLF_ESCAPE, &sl->flags); clear_bit(SLF_ESCAPE, &sl->flags);
sl->rcount = 0; sl->rcount = 0;
return; return;
@@ -1015,14 +1011,12 @@ static void slip_unesc(struct slip *sl, unsigned char s)
set_bit(SLF_ESCAPE, &sl->flags); set_bit(SLF_ESCAPE, &sl->flags);
return; return;
case ESC_ESC: case ESC_ESC:
if (test_and_clear_bit(SLF_ESCAPE, &sl->flags)) { if (test_and_clear_bit(SLF_ESCAPE, &sl->flags))
s = ESC; s = ESC;
}
break; break;
case ESC_END: case ESC_END:
if (test_and_clear_bit(SLF_ESCAPE, &sl->flags)) { if (test_and_clear_bit(SLF_ESCAPE, &sl->flags))
s = END; s = END;
}
break; break;
} }
if (!test_bit(SLF_ERROR, &sl->flags)) { if (!test_bit(SLF_ERROR, &sl->flags)) {
@@ -1041,8 +1035,7 @@ static void slip_unesc(struct slip *sl, unsigned char s)
* 6 BIT SLIP ENCAPSULATION * * 6 BIT SLIP ENCAPSULATION *
************************************************************************/ ************************************************************************/
int static int slip_esc6(unsigned char *s, unsigned char *d, int len)
slip_esc6(unsigned char *s, unsigned char *d, int len)
{ {
unsigned char *ptr = d; unsigned char *ptr = d;
unsigned char c; unsigned char c;
@@ -1079,8 +1072,7 @@ slip_esc6(unsigned char *s, unsigned char *d, int len)
return ptr - d; return ptr - d;
} }
void static void slip_unesc6(struct slip *sl, unsigned char s)
slip_unesc6(struct slip *sl, unsigned char s)
{ {
unsigned char c; unsigned char c;
@@ -1091,9 +1083,9 @@ slip_unesc6(struct slip *sl, unsigned char s)
clear_bit(SLF_KEEPTEST, &sl->flags); clear_bit(SLF_KEEPTEST, &sl->flags);
#endif #endif
if (!test_and_clear_bit(SLF_ERROR, &sl->flags) && (sl->rcount > 2)) { if (!test_and_clear_bit(SLF_ERROR, &sl->flags)
&& (sl->rcount > 2))
sl_bump(sl); sl_bump(sl);
}
sl->rcount = 0; sl->rcount = 0;
sl->xbits = 0; sl->xbits = 0;
sl->xdata = 0; sl->xdata = 0;
@@ -1117,16 +1109,16 @@ slip_unesc6(struct slip *sl, unsigned char s)
#endif /* CONFIG_SLIP_MODE_SLIP6 */ #endif /* CONFIG_SLIP_MODE_SLIP6 */
/* Perform I/O control on an active SLIP channel. */ /* Perform I/O control on an active SLIP channel. */
static int slip_ioctl(struct tty_struct *tty, struct file *file, unsigned int cmd, unsigned long arg) static int slip_ioctl(struct tty_struct *tty, struct file *file,
unsigned int cmd, unsigned long arg)
{ {
struct slip *sl = (struct slip *) tty->disc_data; struct slip *sl = tty->disc_data;
unsigned int tmp; unsigned int tmp;
int __user *p = (int __user *)arg; int __user *p = (int __user *)arg;
/* First make sure we're connected. */ /* First make sure we're connected. */
if (!sl || sl->magic != SLIP_MAGIC) { if (!sl || sl->magic != SLIP_MAGIC)
return -EINVAL; return -EINVAL;
}
switch (cmd) { switch (cmd) {
case SIOCGIFNAME: case SIOCGIFNAME:
@@ -1144,20 +1136,17 @@ static int slip_ioctl(struct tty_struct *tty, struct file *file, unsigned int cm
if (get_user(tmp, p)) if (get_user(tmp, p))
return -EFAULT; return -EFAULT;
#ifndef SL_INCLUDE_CSLIP #ifndef SL_INCLUDE_CSLIP
if (tmp & (SL_MODE_CSLIP|SL_MODE_ADAPTIVE)) { if (tmp & (SL_MODE_CSLIP|SL_MODE_ADAPTIVE))
return -EINVAL; return -EINVAL;
}
#else #else
if ((tmp & (SL_MODE_ADAPTIVE | SL_MODE_CSLIP)) == if ((tmp & (SL_MODE_ADAPTIVE | SL_MODE_CSLIP)) ==
(SL_MODE_ADAPTIVE | SL_MODE_CSLIP)) { (SL_MODE_ADAPTIVE | SL_MODE_CSLIP))
/* return -EINVAL; */ /* return -EINVAL; */
tmp &= ~SL_MODE_ADAPTIVE; tmp &= ~SL_MODE_ADAPTIVE;
}
#endif #endif
#ifndef CONFIG_SLIP_MODE_SLIP6 #ifndef CONFIG_SLIP_MODE_SLIP6
if (tmp & SL_MODE_SLIP6) { if (tmp & SL_MODE_SLIP6)
return -EINVAL; return -EINVAL;
}
#endif #endif
sl->mode = tmp; sl->mode = tmp;
sl->dev->type = ARPHRD_SLIP + sl->mode; sl->dev->type = ARPHRD_SLIP + sl->mode;
@@ -1179,12 +1168,13 @@ static int slip_ioctl(struct tty_struct *tty, struct file *file, unsigned int cm
spin_unlock_bh(&sl->lock); spin_unlock_bh(&sl->lock);
return -ENODEV; return -ENODEV;
} }
if ((sl->keepalive = (unchar) tmp) != 0) { sl->keepalive = (u8)tmp;
mod_timer(&sl->keepalive_timer, jiffies+sl->keepalive*HZ); if (sl->keepalive != 0) {
mod_timer(&sl->keepalive_timer,
jiffies + sl->keepalive * HZ);
set_bit(SLF_KEEPTEST, &sl->flags); set_bit(SLF_KEEPTEST, &sl->flags);
} else { } else
del_timer(&sl->keepalive_timer); del_timer(&sl->keepalive_timer);
}
spin_unlock_bh(&sl->lock); spin_unlock_bh(&sl->lock);
return 0; return 0;
@@ -1203,12 +1193,13 @@ static int slip_ioctl(struct tty_struct *tty, struct file *file, unsigned int cm
spin_unlock_bh(&sl->lock); spin_unlock_bh(&sl->lock);
return -ENODEV; return -ENODEV;
} }
if ((sl->outfill = (unchar) tmp) != 0){ sl->outfill = (u8)tmp;
mod_timer(&sl->outfill_timer, jiffies+sl->outfill*HZ); if (sl->outfill != 0) {
mod_timer(&sl->outfill_timer,
jiffies + sl->outfill * HZ);
set_bit(SLF_OUTWAIT, &sl->flags); set_bit(SLF_OUTWAIT, &sl->flags);
} else { } else
del_timer(&sl->outfill_timer); del_timer(&sl->outfill_timer);
}
spin_unlock_bh(&sl->lock); spin_unlock_bh(&sl->lock);
return 0; return 0;
@@ -1251,14 +1242,15 @@ static int sl_ioctl(struct net_device *dev,struct ifreq *rq,int cmd)
spin_unlock_bh(&sl->lock); spin_unlock_bh(&sl->lock);
return -EINVAL; return -EINVAL;
} }
sl->keepalive = (unchar) *p; sl->keepalive = (u8)*p;
if (sl->keepalive != 0) { if (sl->keepalive != 0) {
sl->keepalive_timer.expires=jiffies+sl->keepalive*HZ; sl->keepalive_timer.expires =
mod_timer(&sl->keepalive_timer, jiffies+sl->keepalive*HZ); jiffies + sl->keepalive * HZ;
mod_timer(&sl->keepalive_timer,
jiffies + sl->keepalive * HZ);
set_bit(SLF_KEEPTEST, &sl->flags); set_bit(SLF_KEEPTEST, &sl->flags);
} else { } else
del_timer(&sl->keepalive_timer); del_timer(&sl->keepalive_timer);
}
break; break;
case SIOCGKEEPALIVE: case SIOCGKEEPALIVE:
@@ -1270,12 +1262,13 @@ static int sl_ioctl(struct net_device *dev,struct ifreq *rq,int cmd)
spin_unlock_bh(&sl->lock); spin_unlock_bh(&sl->lock);
return -EINVAL; return -EINVAL;
} }
if ((sl->outfill = (unchar)*p) != 0){ sl->outfill = (u8)*p;
mod_timer(&sl->outfill_timer, jiffies+sl->outfill*HZ); if (sl->outfill != 0) {
mod_timer(&sl->outfill_timer,
jiffies + sl->outfill * HZ);
set_bit(SLF_OUTWAIT, &sl->flags); set_bit(SLF_OUTWAIT, &sl->flags);
} else { } else
del_timer(&sl->outfill_timer); del_timer(&sl->outfill_timer);
}
break; break;
case SIOCGOUTFILL: case SIOCGOUTFILL:
@@ -1286,7 +1279,8 @@ static int sl_ioctl(struct net_device *dev,struct ifreq *rq,int cmd)
/* Resolve race condition, when ioctl'ing hanged up /* Resolve race condition, when ioctl'ing hanged up
and opened by another process device. and opened by another process device.
*/ */
if (sl->tty != current->signal->tty && sl->pid != current->pid) { if (sl->tty != current->signal->tty &&
sl->pid != current->pid) {
spin_unlock_bh(&sl->lock); spin_unlock_bh(&sl->lock);
return -EPERM; return -EPERM;
} }
@@ -1335,14 +1329,16 @@ static int __init slip_init(void)
printk(KERN_INFO "SLIP linefill/keepalive option.\n"); printk(KERN_INFO "SLIP linefill/keepalive option.\n");
#endif #endif
slip_devs = kzalloc(sizeof(struct net_device *)*slip_maxdev, GFP_KERNEL); slip_devs = kzalloc(sizeof(struct net_device *)*slip_maxdev,
GFP_KERNEL);
if (!slip_devs) { if (!slip_devs) {
printk(KERN_ERR "SLIP: Can't allocate slip devices array! Uaargh! (-> No SLIP available)\n"); printk(KERN_ERR "SLIP: Can't allocate slip devices array.\n");
return -ENOMEM; return -ENOMEM;
} }
/* Fill in our line protocol discipline, and register it */ /* Fill in our line protocol discipline, and register it */
if ((status = tty_register_ldisc(N_SLIP, &sl_ldisc)) != 0) { status = tty_register_ldisc(N_SLIP, &sl_ldisc);
if (status != 0) {
printk(KERN_ERR "SLIP: can't register line discipline (err = %d)\n", status); printk(KERN_ERR "SLIP: can't register line discipline (err = %d)\n", status);
kfree(slip_devs); kfree(slip_devs);
} }
@@ -1402,11 +1398,10 @@ static void __exit slip_exit(void)
kfree(slip_devs); kfree(slip_devs);
slip_devs = NULL; slip_devs = NULL;
if ((i = tty_unregister_ldisc(N_SLIP))) i = tty_unregister_ldisc(N_SLIP);
{ if (i != 0)
printk(KERN_ERR "SLIP: can't unregister line discipline (err = %d)\n", i); printk(KERN_ERR "SLIP: can't unregister line discipline (err = %d)\n", i);
} }
}
module_init(slip_init); module_init(slip_init);
module_exit(slip_exit); module_exit(slip_exit);
@@ -1426,10 +1421,8 @@ static void sl_outfill(unsigned long sls)
if (sl->tty == NULL) if (sl->tty == NULL)
goto out; goto out;
if(sl->outfill) if (sl->outfill) {
{ if (test_bit(SLF_OUTWAIT, &sl->flags)) {
if( test_bit(SLF_OUTWAIT, &sl->flags) )
{
/* no packets were transmitted, do outfill */ /* no packets were transmitted, do outfill */
#ifdef CONFIG_SLIP_MODE_SLIP6 #ifdef CONFIG_SLIP_MODE_SLIP6
unsigned char s = (sl->mode & SL_MODE_SLIP6)?0x70:END; unsigned char s = (sl->mode & SL_MODE_SLIP6)?0x70:END;
@@ -1437,13 +1430,11 @@ static void sl_outfill(unsigned long sls)
unsigned char s = END; unsigned char s = END;
#endif #endif
/* put END into tty queue. Is it right ??? */ /* put END into tty queue. Is it right ??? */
if (!netif_queue_stopped(sl->dev)) if (!netif_queue_stopped(sl->dev)) {
{
/* if device busy no outfill */ /* if device busy no outfill */
sl->tty->driver->write(sl->tty, &s, 1); sl->tty->driver->write(sl->tty, &s, 1);
} }
} } else
else
set_bit(SLF_OUTWAIT, &sl->flags); set_bit(SLF_OUTWAIT, &sl->flags);
mod_timer(&sl->outfill_timer, jiffies+sl->outfill*HZ); mod_timer(&sl->outfill_timer, jiffies+sl->outfill*HZ);
@@ -1461,24 +1452,22 @@ static void sl_keepalive(unsigned long sls)
if (sl->tty == NULL) if (sl->tty == NULL)
goto out; goto out;
if( sl->keepalive) if (sl->keepalive) {
{ if (test_bit(SLF_KEEPTEST, &sl->flags)) {
if(test_bit(SLF_KEEPTEST, &sl->flags))
{
/* keepalive still high :(, we must hangup */ /* keepalive still high :(, we must hangup */
if( sl->outfill ) /* outfill timer must be deleted too */ if (sl->outfill)
/* outfill timer must be deleted too */
(void)del_timer(&sl->outfill_timer); (void)del_timer(&sl->outfill_timer);
printk(KERN_DEBUG "%s: no packets received during keepalive timeout, hangup.\n", sl->dev->name); printk(KERN_DEBUG "%s: no packets received during keepalive timeout, hangup.\n", sl->dev->name);
tty_hangup(sl->tty); /* this must hangup tty & close slip */ /* this must hangup tty & close slip */
tty_hangup(sl->tty);
/* I think we need not something else */ /* I think we need not something else */
goto out; goto out;
} } else
else
set_bit(SLF_KEEPTEST, &sl->flags); set_bit(SLF_KEEPTEST, &sl->flags);
mod_timer(&sl->keepalive_timer, jiffies+sl->keepalive*HZ); mod_timer(&sl->keepalive_timer, jiffies+sl->keepalive*HZ);
} }
out: out:
spin_unlock(&sl->lock); spin_unlock(&sl->lock);
} }