lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[MYRI_SBUS]: Prevent that myri_do_handshake lies about ticks.

Browse Source 
With '<=' tick can be incremented up to 26, The last loop is redundant
since even when 'softstate' becomes 'STATE_READY', 'if (tick > 25)'
will still cause the function to return -1,

Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Roel Kluin
2007-11-13 03:16:17 -08:00
committed by David S. Miller
parent 81d9ddae85
commit 9db7720cca
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/myri_sbus.c
View File

@@ -134,7 +134,7 @@ static int myri_do_handshake(struct myri_eth *mp)
myri_disable_irq(mp->lregs, cregs); myri_disable_irq(mp->lregs, cregs);
while (tick++ <= 25) { while (tick++ < 25) {
u32 softstate; u32 softstate;
/* Wake it up. */ /* Wake it up. */