lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Bluetooth: hidp: fix buffer overflow

Browse Source 
Struct ca is copied from userspace. It is not checked whether the "name"
field is NULL terminated, which allows local users to obtain potentially
sensitive information from kernel stack memory, via a HIDPCONNADD command.

This vulnerability is similar to CVE-2011-1079.

Signed-off-by: Young Xiao <YangX92@hotmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Cc: stable@vger.kernel.org
This commit is contained in:
Young Xiao 2019-04-12 15:24:30 +08:00 committed by Marcel Holtmann
parent 7362334054
commit a1616a5ac9
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
net/bluetooth/hidp/sock.c
View File

@ -75,6 +75,7 @@ static int do_hidp_sock_ioctl(struct socket *sock, unsigned int cmd, void __user
sockfd_put(csock); sockfd_put(csock);
return err; return err;
} }
ca.name[sizeof(ca.name)-1] = 0;
err = hidp_connection_add(&ca, csock, isock); err = hidp_connection_add(&ca, csock, isock);
if (!err && copy_to_user(argp, &ca, sizeof(ca))) if (!err && copy_to_user(argp, &ca, sizeof(ca)))