lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

drivers/rtc: don't check resource with devm_ioremap_resource

Browse Source 
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Acked-by: Stephen Warren <swarren@nvidia.com>
This commit is contained in:
Wolfram Sang
2013-05-12 15:19:50 +02:00
parent 362e9cd2f5
commit a177c3ac25
4 changed files with 0 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/rtc/rtc-nuc900.c
View File

@@ -234,11 +234,6 @@ static int __init nuc900_rtc_probe(struct platform_device *pdev)
return -ENOMEM; return -ENOMEM;
} }
res = platform_get_resource(pdev, IORESOURCE_MEM, 0); res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!res) {
dev_err(&pdev->dev, "platform_get_resource failed\n");
return -ENXIO;
}
nuc900_rtc->rtc_reg = devm_ioremap_resource(&pdev->dev, res); nuc900_rtc->rtc_reg = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(nuc900_rtc->rtc_reg)) if (IS_ERR(nuc900_rtc->rtc_reg))
return PTR_ERR(nuc900_rtc->rtc_reg); return PTR_ERR(nuc900_rtc->rtc_reg);

5
drivers/rtc/rtc-omap.c
View File

@@ -347,11 +347,6 @@ static int __init omap_rtc_probe(struct platform_device *pdev)
} }
res = platform_get_resource(pdev, IORESOURCE_MEM, 0); res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!res) {
pr_debug("%s: RTC resource data missing\n", pdev->name);
return -ENOENT;
}
rtc_base = devm_ioremap_resource(&pdev->dev, res); rtc_base = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(rtc_base)) if (IS_ERR(rtc_base))
return PTR_ERR(rtc_base); return PTR_ERR(rtc_base);

5
drivers/rtc/rtc-s3c.c
View File

@@ -477,11 +477,6 @@ static int s3c_rtc_probe(struct platform_device *pdev)
/* get the memory region */ /* get the memory region */
res = platform_get_resource(pdev, IORESOURCE_MEM, 0); res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (res == NULL) {
dev_err(&pdev->dev, "failed to get memory region resource\n");
return -ENOENT;
}
s3c_rtc_base = devm_ioremap_resource(&pdev->dev, res); s3c_rtc_base = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(s3c_rtc_base)) if (IS_ERR(s3c_rtc_base))
return PTR_ERR(s3c_rtc_base); return PTR_ERR(s3c_rtc_base);

6
drivers/rtc/rtc-tegra.c
View File

@@ -322,12 +322,6 @@ static int __init tegra_rtc_probe(struct platform_device *pdev)
return -ENOMEM; return -ENOMEM;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0); res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!res) {
dev_err(&pdev->dev,
"Unable to allocate resources for device.\n");
return -EBUSY;
}
info->rtc_base = devm_ioremap_resource(&pdev->dev, res); info->rtc_base = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(info->rtc_base)) if (IS_ERR(info->rtc_base))
return PTR_ERR(info->rtc_base); return PTR_ERR(info->rtc_base);