lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Btrfs: avoid possible NULL deref in io_ctl_drop_pages()

Browse Source 
If we run into some failure path in io_ctl_prepare_pages(),
io_ctl->pages[] array may have some NULL pointers.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
This commit is contained in:
Li Zefan
2012-01-09 14:27:42 +08:00
parent db804f23a7
commit a1ee5a4581
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
fs/btrfs/free-space-cache.c
View File

@@ -319,11 +319,13 @@ static void io_ctl_drop_pages(struct io_ctl *io_ctl)
io_ctl_unmap_page(io_ctl); io_ctl_unmap_page(io_ctl);
for (i = 0; i < io_ctl->num_pages; i++) { for (i = 0; i < io_ctl->num_pages; i++) {
if (io_ctl->pages[i]) {
ClearPageChecked(io_ctl->pages[i]); ClearPageChecked(io_ctl->pages[i]);
unlock_page(io_ctl->pages[i]); unlock_page(io_ctl->pages[i]);
page_cache_release(io_ctl->pages[i]); page_cache_release(io_ctl->pages[i]);
} }
} }
}
static int io_ctl_prepare_pages(struct io_ctl *io_ctl, struct inode *inode, static int io_ctl_prepare_pages(struct io_ctl *io_ctl, struct inode *inode,
int uptodate) int uptodate)