lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

IB/srp: Check match_strdup() return

Browse Source 
Checks if the kmalloc in match_strdup() was successful, and bail out
on looking at the token if it failed.

Signed-off-by: Ishai Rabinovitz <ishai@mellanox.co.il>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
This commit is contained in:
Ishai Rabinovitz
2007-01-16 17:20:25 +02:00
committed by Roland Dreier
parent 2596627c5c
commit a20f3a6d7e
1 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
drivers/infiniband/ulp/srp/ib_srp.c
View File

@@ -1621,18 +1621,30 @@ static int srp_parse_options(const char *buf, struct srp_target_port *target)
switch (token) { switch (token) {
case SRP_OPT_ID_EXT: case SRP_OPT_ID_EXT:
p = match_strdup(args); p = match_strdup(args);
if (!p) {
ret = -ENOMEM;
goto out;
}
target->id_ext = cpu_to_be64(simple_strtoull(p, NULL, 16)); target->id_ext = cpu_to_be64(simple_strtoull(p, NULL, 16));
kfree(p); kfree(p);
break; break;
case SRP_OPT_IOC_GUID: case SRP_OPT_IOC_GUID:
p = match_strdup(args); p = match_strdup(args);
if (!p) {
ret = -ENOMEM;
goto out;
}
target->ioc_guid = cpu_to_be64(simple_strtoull(p, NULL, 16)); target->ioc_guid = cpu_to_be64(simple_strtoull(p, NULL, 16));
kfree(p); kfree(p);
break; break;
case SRP_OPT_DGID: case SRP_OPT_DGID:
p = match_strdup(args); p = match_strdup(args);
if (!p) {
ret = -ENOMEM;
goto out;
}
if (strlen(p) != 32) { if (strlen(p) != 32) {
printk(KERN_WARNING PFX "bad dest GID parameter '%s'\n", p); printk(KERN_WARNING PFX "bad dest GID parameter '%s'\n", p);
kfree(p); kfree(p);
@@ -1656,6 +1668,10 @@ static int srp_parse_options(const char *buf, struct srp_target_port *target)
case SRP_OPT_SERVICE_ID: case SRP_OPT_SERVICE_ID:
p = match_strdup(args); p = match_strdup(args);
if (!p) {
ret = -ENOMEM;
goto out;
}
target->service_id = cpu_to_be64(simple_strtoull(p, NULL, 16)); target->service_id = cpu_to_be64(simple_strtoull(p, NULL, 16));
kfree(p); kfree(p);
break; break;
@@ -1693,6 +1709,10 @@ static int srp_parse_options(const char *buf, struct srp_target_port *target)
case SRP_OPT_INITIATOR_EXT: case SRP_OPT_INITIATOR_EXT:
p = match_strdup(args); p = match_strdup(args);
if (!p) {
ret = -ENOMEM;
goto out;
}
target->initiator_ext = cpu_to_be64(simple_strtoull(p, NULL, 16)); target->initiator_ext = cpu_to_be64(simple_strtoull(p, NULL, 16));
kfree(p); kfree(p);
break; break;