lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[ALSA] fix usbmixer double kfree

Browse Source 
Modules: USB generic driver

snd_ctl_add() kfree's the kcontrol already if we fail there,
so this driver is currently doing a double kfree.

Coverity bug #959

Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Dave Jones
2006-03-06 13:26:10 +01:00
committed by Jaroslav Kysela
parent 4fcf0117d5
commit a2df813bea
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
sound/usb/usbmixer.c
View File

@@ -434,7 +434,6 @@ static int add_control_to_empty(struct mixer_build *state, struct snd_kcontrol *
kctl->id.index++; kctl->id.index++;
if ((err = snd_ctl_add(state->chip->card, kctl)) < 0) { if ((err = snd_ctl_add(state->chip->card, kctl)) < 0) {
snd_printd(KERN_ERR "cannot add control (err = %d)\n", err); snd_printd(KERN_ERR "cannot add control (err = %d)\n", err);
snd_ctl_free_one(kctl);
return err; return err;
} }
cval->elem_id = &kctl->id; cval->elem_id = &kctl->id;