lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

UDF: Close small mem leak in udf_find_entry()

Browse Source 
Hi,

There's a small memory leak in fs/udf/namei.c::udf_find_entry().

We dynamically allocate memory for 'fname' with kmalloc() and in most
situations we free it before we leave the function, but there is one
situation where we do not (but should). This patch closes the leak by
jumping to the 'out_ok' label which does the correct cleanup rather than
doing half the cleanup and returning directly.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Jan Kara <jack@suse.cz>
This commit is contained in:
Jesper Juhl
2010-12-12 23:18:15 +01:00
committed by Jan Kara
parent 4651c5900e
commit a4264b3f40
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
fs/udf/namei.c
View File

@@ -227,10 +227,8 @@ static struct fileIdentDesc *udf_find_entry(struct inode *dir,
} }
if ((cfi->fileCharacteristics & FID_FILE_CHAR_PARENT) && if ((cfi->fileCharacteristics & FID_FILE_CHAR_PARENT) &&
isdotdot) { isdotdot)
brelse(epos.bh); goto out_ok;
return fi;
}
if (!lfi) if (!lfi)
continue; continue;