lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

pid namespaces: round up the API

Browse Source 
The set of functions process_session, task_session, process_group and
task_pgrp is confusing, as the names can be mixed with each other when looking
at the code for a long time.

The proposals are to
* equip the functions that return the integer with _nr suffix to
  represent that fact,
* and to make all functions work with task (not process) by making
  the common prefix of the same name.

For monotony the routines signal_session() and set_signal_session() are
replaced with task_session_nr() and set_task_session(), especially since they
are only used with the explicit task->signal dereference.

Signed-off-by: Pavel Emelianov <xemul@openvz.org>
Acked-by: Serge E. Hallyn <serue@us.ibm.com>
Cc: Kirill Korotaev <dev@openvz.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Cedric Le Goater <clg@fr.ibm.com>
Cc: Herbert Poetzl <herbert@13thfloor.at>
Cc: Sukadev Bhattiprolu <sukadev@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Pavel Emelianov
2007-10-18 23:39:46 -07:00
committed by Linus Torvalds
parent 858d72ead4
commit a47afb0f9d
19 changed files with 48 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
include/linux/sched.h
View File

@@ -1188,24 +1188,19 @@ static inline int rt_task(struct task_struct *p)
return rt_prio(p->prio);
}
static inline pid_t process_group(struct task_struct *tsk)
static inline pid_t task_pgrp_nr(struct task_struct *tsk)
{
return tsk->signal->pgrp;
}
static inline pid_t signal_session(struct signal_struct *sig)
static inline pid_t task_session_nr(struct task_struct *tsk)
{
return sig->__session;
return tsk->signal->__session;
}
static inline pid_t process_session(struct task_struct *tsk)
static inline void set_task_session(struct task_struct *tsk, pid_t session)
{
return signal_session(tsk->signal);
}
static inline void set_signal_session(struct signal_struct *sig, pid_t session)
{
sig->__session = session;
tsk->signal->__session = session;
}
static inline struct pid *task_pid(struct task_struct *task)