lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

exofs: deprecate the commands pending counter

Browse Source 
One leftover from the days of IBM's original code, is an SB counter
that counts in-flight asynchronous commands. And a piece of code that
waits for the counter to reach zero at unmount. I guess it might have
been needed then, cause of some reference missing or something.

I'm not removing it yet but am putting a warning message if ever this
counter triggers at unmount. If I'll never see it triggers or reported
I'll remove the counter for good.
(I had this print as a debug output for a long time and never had it
 trigger)

Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
This commit is contained in:
Boaz Harrosh
2011-02-07 18:12:15 +02:00
parent 1cea312ad4
commit a49fb4c3d0
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
fs/exofs/super.c
View File

@@ -409,6 +409,10 @@ static void exofs_put_super(struct super_block *sb)
for (num_pend = atomic_read(&sbi->s_curr_pending); num_pend > 0; for (num_pend = atomic_read(&sbi->s_curr_pending); num_pend > 0;
num_pend = atomic_read(&sbi->s_curr_pending)) { num_pend = atomic_read(&sbi->s_curr_pending)) {
wait_queue_head_t wq; wait_queue_head_t wq;
printk(KERN_NOTICE "%s: !!Pending operations in flight. "
"This is a BUG. please report to osd-dev@open-osd.org\n",
__func__);
init_waitqueue_head(&wq); init_waitqueue_head(&wq);
wait_event_timeout(wq, wait_event_timeout(wq,
(atomic_read(&sbi->s_curr_pending) == 0), (atomic_read(&sbi->s_curr_pending) == 0),