lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[SPARC64]: Don't use in/local regs for ldx/stx data in N1 memcpy.

Browse Source 
It doesn't matter for use in 64-bit objects, but when used in
32-bit environments the top 32-bits of the local and in
registers will get chopped off on the next register window
spill/restore which leads to difficult to track down and
subtle bugs.

Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
David S. Miller
2007-10-02 16:17:17 -07:00
parent f778089cb2
commit a4aa2e867c
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
arch/sparc64/lib/NGmemcpy.S
View File

@@ -321,11 +321,11 @@ FUNC_NAME: /* %i0=dst, %i1=src, %i2=len */
andn %i2, 0xf, %i4 andn %i2, 0xf, %i4
and %i2, 0xf, %i2 and %i2, 0xf, %i2
1: subcc %i4, 0x10, %i4 1: subcc %i4, 0x10, %i4
EX_LD(LOAD(ldx, %i1, %i5)) EX_LD(LOAD(ldx, %i1, %o4))
add %i1, 0x08, %i1 add %i1, 0x08, %i1
EX_LD(LOAD(ldx, %i1, %g1)) EX_LD(LOAD(ldx, %i1, %g1))
sub %i1, 0x08, %i1 sub %i1, 0x08, %i1
EX_ST(STORE(stx, %i5, %i1 + %i3)) EX_ST(STORE(stx, %o4, %i1 + %i3))
add %i1, 0x8, %i1 add %i1, 0x8, %i1
EX_ST(STORE(stx, %g1, %i1 + %i3)) EX_ST(STORE(stx, %g1, %i1 + %i3))
bgu,pt %XCC, 1b bgu,pt %XCC, 1b
@@ -334,8 +334,8 @@ FUNC_NAME: /* %i0=dst, %i1=src, %i2=len */
be,pt %XCC, 1f be,pt %XCC, 1f
nop nop
sub %i2, 0x8, %i2 sub %i2, 0x8, %i2
EX_LD(LOAD(ldx, %i1, %i5)) EX_LD(LOAD(ldx, %i1, %o4))
EX_ST(STORE(stx, %i5, %i1 + %i3)) EX_ST(STORE(stx, %o4, %i1 + %i3))
add %i1, 0x8, %i1 add %i1, 0x8, %i1
1: andcc %i2, 0x4, %g0 1: andcc %i2, 0x4, %g0
be,pt %XCC, 1f be,pt %XCC, 1f