lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[PATCH] libata: don't request sense if the port is frozen

Browse Source 
If EH command is issued to a frozen port, it fails with AC_ERR_SYSTEM.
libata used to request sense even when the port is frozen needlessly
adding AC_ERR_SYSTEM to err_mask.  Don't do it.

Signed-off-by: Tejun Heo <htejun@gmail.com>
This commit is contained in:
Tejun Heo
2006-11-21 10:40:51 +09:00
parent 6a36261e63
commit a569a30d30
1 changed files with 15 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
drivers/ata/libata-eh.c
View File

@@ -1136,19 +1136,21 @@ static unsigned int ata_eh_analyze_tf(struct ata_queued_cmd *qc,
break; break;
case ATA_DEV_ATAPI: case ATA_DEV_ATAPI:
tmp = atapi_eh_request_sense(qc->dev, if (!(qc->ap->pflags & ATA_PFLAG_FROZEN)) {
qc->scsicmd->sense_buffer); tmp = atapi_eh_request_sense(qc->dev,
if (!tmp) { qc->scsicmd->sense_buffer);
/* ATA_QCFLAG_SENSE_VALID is used to tell if (!tmp) {
* atapi_qc_complete() that sense data is /* ATA_QCFLAG_SENSE_VALID is used to
* already valid. * tell atapi_qc_complete() that sense
* * data is already valid.
* TODO: interpret sense data and set *
* appropriate err_mask. * TODO: interpret sense data and set
*/ * appropriate err_mask.
qc->flags |= ATA_QCFLAG_SENSE_VALID; */
} else qc->flags |= ATA_QCFLAG_SENSE_VALID;
qc->err_mask |= tmp; } else
qc->err_mask |= tmp;
}
} }
if (qc->err_mask & (AC_ERR_HSM | AC_ERR_TIMEOUT | AC_ERR_ATA_BUS)) if (qc->err_mask & (AC_ERR_HSM | AC_ERR_TIMEOUT | AC_ERR_ATA_BUS))