lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

iwlwifi: LED initialize before registering

Browse Source 
This patch initialize all fields in led before registering it
This fixes oops on initialization

Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Tomas Winkler
2008-03-28 16:21:11 -07:00
committed by John W. Linville
parent c4f552321f
commit a571ea4eb3
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/wireless/iwlwifi/iwl-led.c
View File

@@ -238,18 +238,20 @@ static int iwl_leds_register_led(struct iwl_priv *priv,
led->led_dev.brightness_set = iwl4965_led_brightness_set; led->led_dev.brightness_set = iwl4965_led_brightness_set;
led->led_dev.default_trigger = trigger; led->led_dev.default_trigger = trigger;
led->priv = priv;
led->type = type;
ret = led_classdev_register(device, &led->led_dev); ret = led_classdev_register(device, &led->led_dev);
if (ret) { if (ret) {
IWL_ERROR("Error: failed to register led handler.\n"); IWL_ERROR("Error: failed to register led handler.\n");
return ret; return ret;
} }
led->priv = priv;
led->type = type;
led->registered = 1; led->registered = 1;
if (set_led && led->led_on) if (set_led && led->led_on)
led->led_on(priv, IWL_LED_LINK); led->led_on(priv, IWL_LED_LINK);
return 0; return 0;
} }