lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

rtnetlink: Mask the rta_type when range checking

Browse Source 
Range/validity checks on rta_type in rtnetlink_rcv_msg() do
not account for flags that may be set.  This causes the function
to return -EINVAL when flags are set on the type (for example
NLA_F_NESTED).

Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
Acked-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Vlad Yasevich
2013-03-13 04:18:58 +00:00
committed by David S. Miller
parent 8c6216d7f1
commit a5b8db9144
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
net/core/rtnetlink.c
View File

@@ -2621,7 +2621,7 @@ static int rtnetlink_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
struct rtattr *attr = (void *)nlh + NLMSG_ALIGN(min_len); struct rtattr *attr = (void *)nlh + NLMSG_ALIGN(min_len);
while (RTA_OK(attr, attrlen)) { while (RTA_OK(attr, attrlen)) {
unsigned int flavor = attr->rta_type; unsigned int flavor = attr->rta_type & NLA_TYPE_MASK;
if (flavor) { if (flavor) {
if (flavor > rta_max[sz_idx]) if (flavor > rta_max[sz_idx])
return -EINVAL; return -EINVAL;