lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

mmc: initialize struct mmc_data at declaration time

Browse Source 
Converts from:
	struct mmc_data data;
	memset(&data, 0, sizeof(struct mmc_data));

to:
	struct mmc_data data = {0};

because it's shorter, as performant, and easier to work out whether
initialization has happened.

Signed-off-by: Chris Ball <cjb@laptop.org>
This commit is contained in:
Chris Ball
2011-04-13 23:46:05 -04:00
parent 1278dba167
commit a61ad2b49b
5 changed files with 10 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/mmc/core/sd_ops.c
View File

@@ -245,7 +245,7 @@ int mmc_app_send_scr(struct mmc_card *card, u32 *scr)
int err;
struct mmc_request mrq;
struct mmc_command cmd = {0};
struct mmc_data data;
struct mmc_data data = {0};
struct scatterlist sg;
void *data_buf;
@@ -267,7 +267,6 @@ int mmc_app_send_scr(struct mmc_card *card, u32 *scr)
return -ENOMEM;
memset(&mrq, 0, sizeof(struct mmc_request));
memset(&data, 0, sizeof(struct mmc_data));
mrq.cmd = &cmd;
mrq.data = &data;
@@ -307,7 +306,7 @@ int mmc_sd_switch(struct mmc_card *card, int mode, int group,
{
struct mmc_request mrq;
struct mmc_command cmd = {0};
struct mmc_data data;
struct mmc_data data = {0};
struct scatterlist sg;
BUG_ON(!card);
@@ -319,7 +318,6 @@ int mmc_sd_switch(struct mmc_card *card, int mode, int group,
value &= 0xF;
memset(&mrq, 0, sizeof(struct mmc_request));
memset(&data, 0, sizeof(struct mmc_data));
mrq.cmd = &cmd;
mrq.data = &data;
@@ -355,7 +353,7 @@ int mmc_app_sd_status(struct mmc_card *card, void *ssr)
int err;
struct mmc_request mrq;
struct mmc_command cmd = {0};
struct mmc_data data;
struct mmc_data data = {0};
struct scatterlist sg;
BUG_ON(!card);
@@ -369,7 +367,6 @@ int mmc_app_sd_status(struct mmc_card *card, void *ssr)
return err;
memset(&mrq, 0, sizeof(struct mmc_request));
memset(&data, 0, sizeof(struct mmc_data));
mrq.cmd = &cmd;
mrq.data = &data;