lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

staging: wlan-ng: Remove NULL check before kfree

Browse Source 
This patch was generated by the following semantic patch:
// <smpl>
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);

@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;
// </smpl>

Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Ilia Mirkin
2011-03-13 00:29:17 -05:00
committed by Greg Kroah-Hartman
parent 4d527a7adb
commit a6f9c48fdd
2 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/staging/wlan-ng/hfa384x_usb.c
View File

@@ -612,10 +612,8 @@ void hfa384x_destroy(hfa384x_t *hw)
hfa384x_drvr_stop(hw); hfa384x_drvr_stop(hw);
hw->state = HFA384x_STATE_PREINIT; hw->state = HFA384x_STATE_PREINIT;
if (hw->scanresults) { kfree(hw->scanresults);
kfree(hw->scanresults); hw->scanresults = NULL;
hw->scanresults = NULL;
}
/* Now to clean out the auth queue */ /* Now to clean out the auth queue */
while ((skb = skb_dequeue(&hw->authq))) while ((skb = skb_dequeue(&hw->authq)))

3
drivers/staging/wlan-ng/prism2fw.c
View File

@@ -443,8 +443,7 @@ void free_chunks(struct imgchunk *fchunk, unsigned int *nfchunks)
{ {
int i; int i;
for (i = 0; i < *nfchunks; i++) { for (i = 0; i < *nfchunks; i++) {
if (fchunk[i].data != NULL) kfree(fchunk[i].data);
kfree(fchunk[i].data);
} }
*nfchunks = 0; *nfchunks = 0;
memset(fchunk, 0, sizeof(*fchunk)); memset(fchunk, 0, sizeof(*fchunk));