lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

dlm: Avoid that dlm_release_lockspace() incorrectly returns -EBUSY

Browse Source 
When dlm_release_lockspace(ls, 1) is invoked on a busy system
immediately after the last dlm_unlock() AST has finished it can occur
that lkb_idr_is_local() is invoked for the unlocked LKB since removal
from ls_lkbidr only occurs after the AST has returned. If that happens
dlm_release_lockspace(ls, 1) will return -EBUSY instead of releasing
the lockspace. Fix this race condition by changing lkb_idr_is_local()
such that it only returns true for LKB's that have not yet been
unlocked.

Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: David Teigland <teigland@redhat.com>
This commit is contained in:
Bart Van Assche
2013-10-16 14:20:25 +02:00
committed by David Teigland
parent 34ec4de42b
commit a97f4a66d8
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
fs/dlm/lockspace.c
View File

@@ -706,9 +706,7 @@ static int lkb_idr_is_local(int id, void *p, void *data)
{ {
struct dlm_lkb *lkb = p; struct dlm_lkb *lkb = p;
if (!lkb->lkb_nodeid) return lkb->lkb_nodeid == 0 && lkb->lkb_grmode != DLM_LOCK_IV;
return 1;
return 0;
} }
static int lkb_idr_is_any(int id, void *p, void *data) static int lkb_idr_is_any(int id, void *p, void *data)