lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[IPV6]: Cleanup snmp6_alloc_dev()

Browse Source 
This functions is never called with NULL or not setup argument,
so the checks inside are redundant.

Also, the return value is always -ENOMEM, so no need in 
additional variable for this.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Pavel Emelyanov
2007-10-17 21:25:32 -07:00
committed by David S. Miller
parent 16910b9829
commit aaf70ec7fd
1 changed files with 1 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
net/ipv6/addrconf.c
View File

@ -255,11 +255,6 @@ static void addrconf_mod_timer(struct inet6_ifaddr *ifp,
static int snmp6_alloc_dev(struct inet6_dev *idev) static int snmp6_alloc_dev(struct inet6_dev *idev)
{ {
int err = -ENOMEM;
if (!idev || !idev->dev)
return -EINVAL;
if (snmp_mib_init((void **)idev->stats.ipv6, if (snmp_mib_init((void **)idev->stats.ipv6,
sizeof(struct ipstats_mib), sizeof(struct ipstats_mib),
__alignof__(struct ipstats_mib)) < 0) __alignof__(struct ipstats_mib)) < 0)
@ -280,7 +275,7 @@ err_icmpmsg:
err_icmp: err_icmp:
snmp_mib_free((void **)idev->stats.ipv6); snmp_mib_free((void **)idev->stats.ipv6);
err_ip: err_ip:
return err; return -ENOMEM;
} }
static void snmp6_free_dev(struct inet6_dev *idev) static void snmp6_free_dev(struct inet6_dev *idev)