lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

kmemleak: Slightly change the policy on newly allocated objects

Browse Source 
Newly allocated objects are more likely to be reported as false
positives. Kmemleak ignores the reporting of objects younger than 5
seconds. However, this age was calculated after the memory scanning
completed which usually takes longer than 5 seconds. This patch
make the minimum object age calculation in relation to the start of the
memory scanning.

Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
This commit is contained in:
Catalin Marinas
2009-06-26 17:38:29 +01:00
parent 4698c1f2bb
commit acf4968ec9
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
mm/kmemleak.c
View File

@@ -190,7 +190,9 @@ static unsigned long max_addr;
static unsigned long next_scan_yield; static unsigned long next_scan_yield;
static struct task_struct *scan_thread; static struct task_struct *scan_thread;
static unsigned long jiffies_scan_yield; static unsigned long jiffies_scan_yield;
/* used to avoid reporting of recently allocated objects */
static unsigned long jiffies_min_age; static unsigned long jiffies_min_age;
static unsigned long jiffies_last_scan;
/* delay between automatic memory scannings */ /* delay between automatic memory scannings */
static signed long jiffies_scan_wait; static signed long jiffies_scan_wait;
/* enables or disables the task stacks scanning */ /* enables or disables the task stacks scanning */
@@ -284,7 +286,8 @@ static int color_gray(const struct kmemleak_object *object)
static int unreferenced_object(struct kmemleak_object *object) static int unreferenced_object(struct kmemleak_object *object)
{ {
return (object->flags & OBJECT_ALLOCATED) && color_white(object) && return (object->flags & OBJECT_ALLOCATED) && color_white(object) &&
time_is_before_eq_jiffies(object->jiffies + jiffies_min_age); time_before_eq(object->jiffies + jiffies_min_age,
jiffies_last_scan);
} }
/* /*
@@ -927,6 +930,8 @@ static void kmemleak_scan(void)
int i; int i;
int new_leaks = 0; int new_leaks = 0;
jiffies_last_scan = jiffies;
/* prepare the kmemleak_object's */ /* prepare the kmemleak_object's */
rcu_read_lock(); rcu_read_lock();
list_for_each_entry_rcu(object, &object_list, object_list) { list_for_each_entry_rcu(object, &object_list, object_list) {