lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

drm: Make DRM_IOCTL_GET_CLIENT return EINVAL when it can't find client #idx.

Browse Source 
Fixes the getclient test and dritest -c.

Signed-off-by: Dave Airlie <airlied@linux.ie>
This commit is contained in:
Eric Anholt
2007-11-22 18:46:54 +10:00
committed by Dave Airlie
parent 3260f9fdfe
commit b018fcdaa5
1 changed files with 11 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/char/drm/drm_ioctl.c
View File

@@ -235,17 +235,9 @@ int drm_getclient(struct drm_device *dev, void *data,
idx = client->idx; idx = client->idx;
mutex_lock(&dev->struct_mutex); mutex_lock(&dev->struct_mutex);
if (list_empty(&dev->filelist)) {
mutex_unlock(&dev->struct_mutex);
return -EINVAL;
}
i = 0; i = 0;
list_for_each_entry(pt, &dev->filelist, lhead) { list_for_each_entry(pt, &dev->filelist, lhead) {
if (i++ >= idx) if (i++ >= idx) {
break;
}
client->auth = pt->authenticated; client->auth = pt->authenticated;
client->pid = pt->pid; client->pid = pt->pid;
client->uid = pt->uid; client->uid = pt->uid;
@@ -255,6 +247,11 @@ int drm_getclient(struct drm_device *dev, void *data,
return 0; return 0;
} }
}
mutex_unlock(&dev->struct_mutex);
return -EINVAL;
}
/** /**
* Get statistics information. * Get statistics information.