mac80211_hwsim: fix race condition with sta/vif pointers
info->control.sta and control.vif may only be dereferenced during the drv_tx call otherwise could lead to use-after-free bugs. Signed-off-by: Thomas Huehn <thomas@net.t-labs.tu-berlin.de> [reword commit message] Signed-off-by: Johannes Berg <johannes.berg@intel.com>
This commit is contained in:
committed by
Johannes Berg
parent
7f9f78ab96
commit
b0e40e72be
@@ -1540,11 +1540,6 @@ static int hwsim_tx_info_frame_received_nl(struct sk_buff *skb_2,
|
|||||||
/* now send back TX status */
|
/* now send back TX status */
|
||||||
txi = IEEE80211_SKB_CB(skb);
|
txi = IEEE80211_SKB_CB(skb);
|
||||||
|
|
||||||
if (txi->control.vif)
|
|
||||||
hwsim_check_magic(txi->control.vif);
|
|
||||||
if (txi->control.sta)
|
|
||||||
hwsim_check_sta_magic(txi->control.sta);
|
|
||||||
|
|
||||||
ieee80211_tx_info_clear_status(txi);
|
ieee80211_tx_info_clear_status(txi);
|
||||||
|
|
||||||
for (i = 0; i < IEEE80211_TX_MAX_RATES; i++) {
|
for (i = 0; i < IEEE80211_TX_MAX_RATES; i++) {
|
||||||
|
Reference in New Issue
Block a user