lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ip27-rtc: BKL pushdown

Browse Source 
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This commit is contained in:
Arnd Bergmann
2008-05-20 19:16:03 +02:00
committed by Jonathan Corbet
parent 6b0ee363b2
commit b0e54f7c47
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/char/ip27-rtc.c
View File

@@ -27,6 +27,7 @@
#include <linux/bcd.h> #include <linux/bcd.h>
#include <linux/module.h> #include <linux/module.h>
#include <linux/kernel.h> #include <linux/kernel.h>
#include <linux/smp_lock.h>
#include <linux/types.h> #include <linux/types.h>
#include <linux/miscdevice.h> #include <linux/miscdevice.h>
#include <linux/ioport.h> #include <linux/ioport.h>
@@ -163,15 +164,18 @@ static long rtc_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
static int rtc_open(struct inode *inode, struct file *file) static int rtc_open(struct inode *inode, struct file *file)
{ {
lock_kernel();
spin_lock_irq(&rtc_lock); spin_lock_irq(&rtc_lock);
if (rtc_status & RTC_IS_OPEN) { if (rtc_status & RTC_IS_OPEN) {
spin_unlock_irq(&rtc_lock); spin_unlock_irq(&rtc_lock);
unlock_kernel();
return -EBUSY; return -EBUSY;
} }
rtc_status |= RTC_IS_OPEN; rtc_status |= RTC_IS_OPEN;
spin_unlock_irq(&rtc_lock); spin_unlock_irq(&rtc_lock);
unlock_kernel();
return 0; return 0;
} }