lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[POWERPC] spufs: spu_find_victim may choose wrong victim

Browse Source 
Need to re-check priority after dropping lock.  Otherwise, a
more favored context may be preempted.

Signed-off-by: Luke Browning <lukebr@linux.vnet.ibm.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
This commit is contained in:
Luke Browning
2007-12-20 16:39:59 +09:00
committed by Paul Mackerras
parent 91569531d1
commit b192541b39
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
arch/powerpc/platforms/cell/spufs/sched.c
View File

@@ -626,10 +626,10 @@ static struct spu *find_victim(struct spu_context *ctx)
} }
spu = victim->spu; spu = victim->spu;
if (!spu) { if (!spu || victim->prio <= ctx->prio) {
/* /*
* This race can happen because we've dropped * This race can happen because we've dropped
* the active list mutex. No a problem, just * the active list mutex. Not a problem, just
* restart the search. * restart the search.
*/ */
mutex_unlock(&victim->state_mutex); mutex_unlock(&victim->state_mutex);