lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[media] m5mols: introduce missing initialization

Browse Source 
The result of one call to a function is tested, and then at the second call
to the same function, the previous result, and not the current result, is
tested again.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression ret;
identifier f;
statement S1,S2;
@@

*ret = f(...);
if (\(ret != 0\|ret < 0\|ret == NULL\)) S1
... when any
*f(...);
if (\(ret != 0\|ret < 0\|ret == NULL\)) S2
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Julia Lawall 2012-08-18 17:25:59 -03:00 committed by Mauro Carvalho Chehab
parent 780d61704c
commit b25b895805
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/media/i2c/m5mols/m5mols_core.c
View File

@ -937,7 +937,7 @@ static int __devinit m5mols_probe(struct i2c_client *client,
if (!ret)
ret = m5mols_init_controls(sd);
m5mols_sensor_power(info, false);
ret = m5mols_sensor_power(info, false);
if (!ret)
return 0;
out_me: