ASoC: smdk_wm9713: fix resource leak in smdk_init error path
Fix the error path to properly free allocated resources. Signed-off-by: Axel Lin <axel.lin@gmail.com> Acked-by: Jassi Brar <jassi.brar@samsung.com> Acked-by: Liam Girdwood <lrg@slimlogic.co.uk> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
This commit is contained in:
@@ -70,24 +70,27 @@ static int __init smdk_init(void)
|
|||||||
|
|
||||||
ret = platform_device_add(smdk_snd_wm9713_device);
|
ret = platform_device_add(smdk_snd_wm9713_device);
|
||||||
if (ret)
|
if (ret)
|
||||||
goto err;
|
goto err1;
|
||||||
|
|
||||||
smdk_snd_ac97_device = platform_device_alloc("soc-audio", -1);
|
smdk_snd_ac97_device = platform_device_alloc("soc-audio", -1);
|
||||||
if (!smdk_snd_ac97_device) {
|
if (!smdk_snd_ac97_device) {
|
||||||
ret = -ENOMEM;
|
ret = -ENOMEM;
|
||||||
goto err;
|
goto err2;
|
||||||
}
|
}
|
||||||
|
|
||||||
platform_set_drvdata(smdk_snd_ac97_device, &smdk);
|
platform_set_drvdata(smdk_snd_ac97_device, &smdk);
|
||||||
|
|
||||||
ret = platform_device_add(smdk_snd_ac97_device);
|
ret = platform_device_add(smdk_snd_ac97_device);
|
||||||
if (ret) {
|
if (ret)
|
||||||
platform_device_put(smdk_snd_ac97_device);
|
goto err3;
|
||||||
goto err;
|
|
||||||
}
|
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
err:
|
|
||||||
|
err3:
|
||||||
|
platform_device_put(smdk_snd_ac97_device);
|
||||||
|
err2:
|
||||||
|
platform_device_del(smdk_snd_wm9713_device);
|
||||||
|
err1:
|
||||||
platform_device_put(smdk_snd_wm9713_device);
|
platform_device_put(smdk_snd_wm9713_device);
|
||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
|
Reference in New Issue
Block a user