lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Bluetooth: Fix failure to release lock in read_index_list()

Browse Source 
If alloc_skb() fails in read_index_list() we'll return -ENOMEM without
releasing 'hci_dev_list_lock'.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
This commit is contained in:
Jesper Juhl
2011-01-14 00:18:49 +01:00
committed by Gustavo F. Padovan
parent 80f5585a29
commit b2c60d42db
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
net/bluetooth/mgmt.c
View File

@@ -111,8 +111,10 @@ static int read_index_list(struct sock *sk)
body_len = sizeof(*ev) + sizeof(*rp) + (2 * count); body_len = sizeof(*ev) + sizeof(*rp) + (2 * count);
skb = alloc_skb(sizeof(*hdr) + body_len, GFP_ATOMIC); skb = alloc_skb(sizeof(*hdr) + body_len, GFP_ATOMIC);
if (!skb) if (!skb) {
read_unlock(&hci_dev_list_lock);
return -ENOMEM; return -ENOMEM;
}
hdr = (void *) skb_put(skb, sizeof(*hdr)); hdr = (void *) skb_put(skb, sizeof(*hdr));
hdr->opcode = cpu_to_le16(MGMT_EV_CMD_COMPLETE); hdr->opcode = cpu_to_le16(MGMT_EV_CMD_COMPLETE);