lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

staging: sep: return -EFAULT on copy_from_user failure

Browse Source 
copy_from_user() returns the number of bytes remaining to be copied,
and it fails if user pointer is invalid, so return -EFAULT
so that the user gets a FAULT.

Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Devendra Naga
2012-10-27 13:23:47 -04:00
committed by Greg Kroah-Hartman
parent 28c4ff6435
commit b58d6021d4
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/staging/sep/sep_main.c
View File

@@ -3431,7 +3431,7 @@ static ssize_t sep_create_dcb_dmatables_context(struct sep_device *sep,
if (copy_from_user(dcb_args, if (copy_from_user(dcb_args,
user_dcb_args, user_dcb_args,
num_dcbs * sizeof(struct build_dcb_struct))) { num_dcbs * sizeof(struct build_dcb_struct))) {
error = -EINVAL; error = -EFAULT;
goto end_function; goto end_function;
} }
@@ -3619,7 +3619,7 @@ static ssize_t sep_create_msgarea_context(struct sep_device *sep,
/* Copy input data to write() to allocated message buffer */ /* Copy input data to write() to allocated message buffer */
if (copy_from_user(*msg_region, msg_user, msg_len)) { if (copy_from_user(*msg_region, msg_user, msg_len)) {
error = -EINVAL; error = -EFAULT;
goto end_function; goto end_function;
} }