lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

staging: comedi: drivers: usbduxsigma.c: fix DMA buffers on stack

Browse Source 
This patch fixes an instance of DMA buffer on stack(being passed to
usb_control_msg)for the USB-DUXsigma Board driver. Found using smatch.

Signed-off-by: Kumar Amit Mehta <gmate.amit@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Kumar Amit Mehta
2013-02-21 22:07:08 -08:00
committed by Greg Kroah-Hartman
parent 47b1be5c0f
commit b5ae11463a
1 changed files with 17 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
drivers/staging/comedi/drivers/usbduxsigma.c
View File

@@ -681,7 +681,11 @@ static void usbduxsub_ao_IsocIrq(struct urb *urb)
static int usbduxsub_start(struct usbduxsub *usbduxsub) static int usbduxsub_start(struct usbduxsub *usbduxsub)
{ {
int errcode = 0; int errcode = 0;
uint8_t local_transfer_buffer[16]; uint8_t *local_transfer_buffer;
local_transfer_buffer = kmalloc(16, GFP_KERNEL);
if (!local_transfer_buffer)
return -ENOMEM;
/* 7f92 to zero */ /* 7f92 to zero */
local_transfer_buffer[0] = 0; local_transfer_buffer[0] = 0;
@@ -702,19 +706,22 @@ static int usbduxsub_start(struct usbduxsub *usbduxsub)
1, 1,
/* Timeout */ /* Timeout */
BULK_TIMEOUT); BULK_TIMEOUT);
if (errcode < 0) { if (errcode < 0)
dev_err(&usbduxsub->interface->dev, dev_err(&usbduxsub->interface->dev,
"comedi_: control msg failed (start)\n"); "comedi_: control msg failed (start)\n");
kfree(local_transfer_buffer);
return errcode; return errcode;
} }
return 0;
}
static int usbduxsub_stop(struct usbduxsub *usbduxsub) static int usbduxsub_stop(struct usbduxsub *usbduxsub)
{ {
int errcode = 0; int errcode = 0;
uint8_t *local_transfer_buffer;
uint8_t local_transfer_buffer[16]; local_transfer_buffer = kmalloc(16, GFP_KERNEL);
if (!local_transfer_buffer)
return -ENOMEM;
/* 7f92 to one */ /* 7f92 to one */
local_transfer_buffer[0] = 1; local_transfer_buffer[0] = 1;
@@ -732,13 +739,13 @@ static int usbduxsub_stop(struct usbduxsub *usbduxsub)
1, 1,
/* Timeout */ /* Timeout */
BULK_TIMEOUT); BULK_TIMEOUT);
if (errcode < 0) { if (errcode < 0)
dev_err(&usbduxsub->interface->dev, dev_err(&usbduxsub->interface->dev,
"comedi_: control msg failed (stop)\n"); "comedi_: control msg failed (stop)\n");
kfree(local_transfer_buffer);
return errcode; return errcode;
} }
return 0;
}
static int usbduxsub_upload(struct usbduxsub *usbduxsub, static int usbduxsub_upload(struct usbduxsub *usbduxsub,
uint8_t *local_transfer_buffer, uint8_t *local_transfer_buffer,