lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

dlm: sanitize work_start() in lowcomms.c

Browse Source 
The create_workqueue() returns NULL if failed rather than ERR_PTR().
Fix error checking and remove unnecessary variable 'error'.

Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: David Teigland <teigland@redhat.com>
This commit is contained in:
Namhyung Kim
2010-12-13 13:42:24 -06:00
committed by David Teigland
parent f92c8dd7a0
commit b9d4105279
1 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
fs/dlm/lowcomms.c
View File

@@ -1468,22 +1468,19 @@ static void work_stop(void)
static int work_start(void) static int work_start(void)
{ {
int error;
recv_workqueue = alloc_workqueue("dlm_recv", WQ_MEM_RECLAIM | recv_workqueue = alloc_workqueue("dlm_recv", WQ_MEM_RECLAIM |
WQ_HIGHPRI | WQ_FREEZEABLE, 0); WQ_HIGHPRI | WQ_FREEZEABLE, 0);
error = IS_ERR(recv_workqueue); if (!recv_workqueue) {
if (error) { log_print("can't start dlm_recv");
log_print("can't start dlm_recv %d", error); return -ENOMEM;
return error;
} }
send_workqueue = alloc_workqueue("dlm_send", WQ_MEM_RECLAIM | send_workqueue = alloc_workqueue("dlm_send", WQ_MEM_RECLAIM |
WQ_HIGHPRI | WQ_FREEZEABLE, 0); WQ_HIGHPRI | WQ_FREEZEABLE, 0);
error = IS_ERR(send_workqueue); if (!send_workqueue) {
if (error) { log_print("can't start dlm_send");
log_print("can't start dlm_send %d", error);
destroy_workqueue(recv_workqueue); destroy_workqueue(recv_workqueue);
return error; return -ENOMEM;
} }
return 0; return 0;