lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

isdn: eicon: Return on error

Browse Source 
When diva_strace_read_uint returns an error, return even from
process_idi_event, because l2_state is uninitialized.

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Karsten Keil <isdn@linux-pingi.de>
Acked-by: Armin Schindler <armin@melware.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Jiri Slaby
2009-11-04 08:30:08 -08:00
committed by David S. Miller
parent 1ea70841f0
commit b9db21f8b9
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/isdn/hardware/eicon/maintidi.c
View File

@@ -960,7 +960,8 @@ static int process_idi_event (diva_strace_context_t* pLib,
if (!strncmp("State\\Layer2 No1", path, pVar->path_length)) { if (!strncmp("State\\Layer2 No1", path, pVar->path_length)) {
char* tmp = &pLib->lines[0].pInterface->Layer2[0]; char* tmp = &pLib->lines[0].pInterface->Layer2[0];
dword l2_state; dword l2_state;
diva_strace_read_uint (pVar, &l2_state); if (diva_strace_read_uint(pVar, &l2_state))
return -1;
switch (l2_state) { switch (l2_state) {
case 0: case 0: