lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fs: add missing unlock in default_llseek()

Browse Source 
A recent change in linux-next, 982d816581 "fs: add SEEK_HOLE and
SEEK_DATA flags" added some direct returns on error, but it should
have been a goto out.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
This commit is contained in:
Dan Carpenter
2011-07-26 17:25:20 +03:00
committed by Al Viro
parent 750e06992d
commit bacb2d816c
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
fs/read_write.c
View File

@@ -166,8 +166,10 @@ loff_t default_llseek(struct file *file, loff_t offset, int origin)
* long as offset isn't at the end of the file then the * long as offset isn't at the end of the file then the
* offset is data. * offset is data.
*/ */
if (offset >= inode->i_size) if (offset >= inode->i_size) {
return -ENXIO; retval = -ENXIO;
goto out;
}
break; break;
case SEEK_HOLE: case SEEK_HOLE:
/* /*
@@ -175,8 +177,10 @@ loff_t default_llseek(struct file *file, loff_t offset, int origin)
* as long as offset isn't i_size or larger, return * as long as offset isn't i_size or larger, return
* i_size. * i_size.
*/ */
if (offset >= inode->i_size) if (offset >= inode->i_size) {
return -ENXIO; retval = -ENXIO;
goto out;
}
offset = inode->i_size; offset = inode->i_size;
break; break;
} }