lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

ocfs2: Check errors from ocfs2_xattr_update_xattr_search()

Browse Source 
The ocfs2_xattr_update_xattr_search() function can return an error when
trying to read blocks off of disk.  The caller needs to check this error
before using those (possibly invalid) blocks.

Signed-off-by: Joel Becker <joel.becker@oracle.com>
Signed-off-by: Mark Fasheh <mfasheh@suse.com>
This commit is contained in:
Joel Becker
2008-10-20 18:25:56 -07:00
committed by Mark Fasheh
parent b37c4d84e9
commit bd60bd37ad
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
fs/ocfs2/xattr.c
View File

@@ -2825,7 +2825,11 @@ static int ocfs2_xattr_create_index_block(struct inode *inode,
if (data_bh) if (data_bh)
ocfs2_journal_dirty(handle, data_bh); ocfs2_journal_dirty(handle, data_bh);
ocfs2_xattr_update_xattr_search(inode, xs, xb_bh, xh_bh); ret = ocfs2_xattr_update_xattr_search(inode, xs, xb_bh, xh_bh);
if (ret) {
mlog_errno(ret);
goto out_commit;
}
/* Change from ocfs2_xattr_header to ocfs2_xattr_tree_root */ /* Change from ocfs2_xattr_header to ocfs2_xattr_tree_root */
memset(&xb->xb_attrs, 0, inode->i_sb->s_blocksize - memset(&xb->xb_attrs, 0, inode->i_sb->s_blocksize -