lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[S390] No execute support cleanup.

Browse Source 
Simplify the signal_return function that checks for the two special
system calls sigreturn and rt_sigreturn. No need to do a page table
walk, a call to copy_from_user while disabled page faults will work
as well.

Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
This commit is contained in:
Martin Schwidefsky
2007-04-27 16:01:44 +02:00
parent 10c1031f70
commit be5ec363e9
1 changed files with 22 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

74
arch/s390/mm/fault.c
View File

@@ -26,9 +26,9 @@
#include <linux/module.h> #include <linux/module.h>
#include <linux/hardirq.h> #include <linux/hardirq.h>
#include <linux/kprobes.h> #include <linux/kprobes.h>
#include <linux/uaccess.h>
#include <asm/system.h> #include <asm/system.h>
#include <asm/uaccess.h>
#include <asm/pgtable.h> #include <asm/pgtable.h>
#include <asm/kdebug.h> #include <asm/kdebug.h>
#include <asm/s390_ext.h> #include <asm/s390_ext.h>
@@ -263,68 +263,38 @@ extern long sys_rt_sigreturn(struct pt_regs *regs);
extern long sys32_sigreturn(struct pt_regs *regs); extern long sys32_sigreturn(struct pt_regs *regs);
extern long sys32_rt_sigreturn(struct pt_regs *regs); extern long sys32_rt_sigreturn(struct pt_regs *regs);
static inline void do_sigreturn(struct mm_struct *mm, struct pt_regs *regs,
int rt)
{
up_read(&mm->mmap_sem);
clear_tsk_thread_flag(current, TIF_SINGLE_STEP);
#ifdef CONFIG_COMPAT
if (test_tsk_thread_flag(current, TIF_31BIT)) {
if (rt)
sys32_rt_sigreturn(regs);
else
sys32_sigreturn(regs);
return;
}
#endif /* CONFIG_COMPAT */
if (rt)
sys_rt_sigreturn(regs);
else
sys_sigreturn(regs);
return;
}
static int signal_return(struct mm_struct *mm, struct pt_regs *regs, static int signal_return(struct mm_struct *mm, struct pt_regs *regs,
unsigned long address, unsigned long error_code) unsigned long address, unsigned long error_code)
{ {
pgd_t *pgd; u16 instruction;
pmd_t *pmd; int rc, compat;
pte_t *pte;
u16 *instruction;
unsigned long pfn, uaddr = regs->psw.addr;
spin_lock(&mm->page_table_lock); pagefault_disable();
pgd = pgd_offset(mm, uaddr); rc = __get_user(instruction, (u16 __user *) regs->psw.addr);
if (pgd_none(*pgd) || unlikely(pgd_bad(*pgd))) pagefault_enable();
goto out_fault; if (rc)
pmd = pmd_offset(pgd, uaddr); return -EFAULT;
if (pmd_none(*pmd) || unlikely(pmd_bad(*pmd)))
goto out_fault;
pte = pte_offset_map(pmd_offset(pgd_offset(mm, uaddr), uaddr), uaddr);
if (!pte || !pte_present(*pte))
goto out_fault;
pfn = pte_pfn(*pte);
if (!pfn_valid(pfn))
goto out_fault;
spin_unlock(&mm->page_table_lock);
instruction = (u16 *) ((pfn << PAGE_SHIFT) + (uaddr & (PAGE_SIZE-1))); up_read(&mm->mmap_sem);
if (*instruction == 0x0a77) clear_tsk_thread_flag(current, TIF_SINGLE_STEP);
do_sigreturn(mm, regs, 0); #ifdef CONFIG_COMPAT
else if (*instruction == 0x0aad) compat = test_tsk_thread_flag(current, TIF_31BIT);
do_sigreturn(mm, regs, 1); if (compat && instruction == 0x0a77)
sys32_sigreturn(regs);
else if (compat && instruction == 0x0aad)
sys32_rt_sigreturn(regs);
else
#endif
if (instruction == 0x0a77)
sys_sigreturn(regs);
else if (instruction == 0x0aad)
sys_rt_sigreturn(regs);
else { else {
printk("- XXX - do_exception: task = %s, primary, NO EXEC "
"-> SIGSEGV\n", current->comm);
up_read(&mm->mmap_sem);
current->thread.prot_addr = address; current->thread.prot_addr = address;
current->thread.trap_no = error_code; current->thread.trap_no = error_code;
do_sigsegv(regs, error_code, SEGV_MAPERR, address); do_sigsegv(regs, error_code, SEGV_MAPERR, address);
} }
return 0; return 0;
out_fault:
spin_unlock(&mm->page_table_lock);
return -EFAULT;
} }
#endif /* CONFIG_S390_EXEC_PROTECT */ #endif /* CONFIG_S390_EXEC_PROTECT */