lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[PATCH] bcm43xx: Workaround init_board vs IRQ race.

Browse Source 
The proper fix for this is to move IRQ enabling to the end of
init_board. But this is nontrivial and needs to be done with care.
Stay with this cheap workaround for now.

Signed-off-by: Michael Buesch <mbuesch@freenet.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Michael Buesch
2006-02-21 17:58:18 +01:00
committed by John W. Linville
parent c4c3beb7d7
commit bf7b876043
1 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
drivers/net/wireless/bcm43xx/bcm43xx_main.c
View File

@@ -2079,12 +2079,19 @@ static irqreturn_t bcm43xx_interrupt_handler(int irq, void *dev_id, struct pt_re
bcm43xx_interrupt_ack(bcm, reason, mask); bcm43xx_interrupt_ack(bcm, reason, mask);
/* disable all IRQs. They are enabled again in the bottom half. */ /* Only accept IRQs, if we are initialized properly.
bcm->irq_savedstate = bcm43xx_interrupt_disable(bcm, BCM43xx_IRQ_ALL); * This avoids an RX race while initializing.
* We should probably not enable IRQs before we are initialized
/* save the reason code and call our bottom half. */ * completely, but some careful work is needed to fix this. I think it
bcm->irq_reason = reason; * is best to stay with this cheap workaround for now... .
tasklet_schedule(&bcm->isr_tasklet); */
if (likely(bcm->initialized)) {
/* disable all IRQs. They are enabled again in the bottom half. */
bcm->irq_savedstate = bcm43xx_interrupt_disable(bcm, BCM43xx_IRQ_ALL);
/* save the reason code and call our bottom half. */
bcm->irq_reason = reason;
tasklet_schedule(&bcm->isr_tasklet);
}
spin_unlock(&bcm->lock); spin_unlock(&bcm->lock);