lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

rsi: Fixed signedness bug reported by static code analyzer.

Browse Source 
Signed-off-by: Fariya Fatima <fariyaf@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Fariya Fatima
2014-04-02 09:29:51 +05:30
committed by John W. Linville
parent b25e77fdfa
commit bff37af7f2
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/wireless/rsi/rsi_91x_mgmt.c
View File

@@ -738,7 +738,7 @@ int rsi_hal_load_key(struct rsi_common *common,
* *
* Return: 0 on success, corresponding error code on failure. * Return: 0 on success, corresponding error code on failure.
*/ */
static u8 rsi_load_bootup_params(struct rsi_common *common) static int rsi_load_bootup_params(struct rsi_common *common)
{ {
struct sk_buff *skb; struct sk_buff *skb;
struct rsi_boot_params *boot_params; struct rsi_boot_params *boot_params;
@@ -1272,6 +1272,7 @@ int rsi_mgmt_pkt_recv(struct rsi_common *common, u8 *msg)
{ {
s32 msg_len = (le16_to_cpu(*(__le16 *)&msg[0]) & 0x0fff); s32 msg_len = (le16_to_cpu(*(__le16 *)&msg[0]) & 0x0fff);
u16 msg_type = (msg[2]); u16 msg_type = (msg[2]);
int ret;
rsi_dbg(FSM_ZONE, "%s: Msg Len: %d, Msg Type: %4x\n", rsi_dbg(FSM_ZONE, "%s: Msg Len: %d, Msg Type: %4x\n",
__func__, msg_len, msg_type); __func__, msg_len, msg_type);
@@ -1284,8 +1285,9 @@ int rsi_mgmt_pkt_recv(struct rsi_common *common, u8 *msg)
if (common->fsm_state == FSM_CARD_NOT_READY) { if (common->fsm_state == FSM_CARD_NOT_READY) {
rsi_set_default_parameters(common); rsi_set_default_parameters(common);
if (rsi_load_bootup_params(common)) ret = rsi_load_bootup_params(common);
return -ENOMEM; if (ret)
return ret;
else else
common->fsm_state = FSM_BOOT_PARAMS_SENT; common->fsm_state = FSM_BOOT_PARAMS_SENT;
} else { } else {