lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

rc80211-pid: fix last_sample initialization

Browse Source 
Fix last_sample initialization. kzalloc'ing the per-STA data wasn't enough,
as jiffies can assume negative values as well. This fixes a bug which
prevented correct PID operation for a while after booting.

Thanks to Michael Buesch for reporting this.

Reported-and-tested-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: Stefano Brivio <stefano.brivio@polimi.it>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Stefano Brivio
2008-01-17 00:38:29 +01:00
committed by David S. Miller
parent f99b751fca
commit c09c7237ea
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
net/mac80211/rc80211_pid_algo.c
View File

@@ -496,6 +496,8 @@ static void *rate_control_pid_alloc_sta(void *priv, gfp_t gfp)
if (spinfo == NULL) if (spinfo == NULL)
return NULL; return NULL;
spinfo->last_sample = jiffies;
#ifdef CONFIG_MAC80211_DEBUGFS #ifdef CONFIG_MAC80211_DEBUGFS
spin_lock_init(&spinfo->events.lock); spin_lock_init(&spinfo->events.lock);
init_waitqueue_head(&spinfo->events.waitqueue); init_waitqueue_head(&spinfo->events.waitqueue);