lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

x86, kmemcheck: Use KERN_WARNING for error reporting

Browse Source 
As suggested by Vegard Nossum, use KERN_WARNING for error
reporting to make sure kmemcheck reports end up in syslog.

Suggested-by: Vegard Nossum <vegard.nossum@gmail.com>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Andrew Morton <akpm@linux-foundation.org>
LKML-Reference: <1261990935.4641.7.camel@penberg-laptop>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
Pekka Enberg
2009-12-28 11:02:15 +02:00
committed by Ingo Molnar
parent d015a09298
commit c0ca9da442
1 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
arch/x86/mm/kmemcheck/error.c
View File

@ -106,26 +106,25 @@ void kmemcheck_error_recall(void)
switch (e->type) { switch (e->type) {
case KMEMCHECK_ERROR_INVALID_ACCESS: case KMEMCHECK_ERROR_INVALID_ACCESS:
printk(KERN_ERR "WARNING: kmemcheck: Caught %d-bit read " printk(KERN_WARNING "WARNING: kmemcheck: Caught %d-bit read from %s memory (%p)\n",
"from %s memory (%p)\n",
8 * e->size, e->state < ARRAY_SIZE(desc) ? 8 * e->size, e->state < ARRAY_SIZE(desc) ?
desc[e->state] : "(invalid shadow state)", desc[e->state] : "(invalid shadow state)",
(void *) e->address); (void *) e->address);
printk(KERN_INFO); printk(KERN_WARNING);
for (i = 0; i < SHADOW_COPY_SIZE; ++i) for (i = 0; i < SHADOW_COPY_SIZE; ++i)
printk("%02x", e->memory_copy[i]); printk(KERN_CONT "%02x", e->memory_copy[i]);
printk("\n"); printk(KERN_CONT "\n");
printk(KERN_INFO); printk(KERN_WARNING);
for (i = 0; i < SHADOW_COPY_SIZE; ++i) { for (i = 0; i < SHADOW_COPY_SIZE; ++i) {
if (e->shadow_copy[i] < ARRAY_SIZE(short_desc)) if (e->shadow_copy[i] < ARRAY_SIZE(short_desc))
printk(" %c", short_desc[e->shadow_copy[i]]); printk(KERN_CONT " %c", short_desc[e->shadow_copy[i]]);
else else
printk(" ?"); printk(KERN_CONT " ?");
} }
printk("\n"); printk(KERN_CONT "\n");
printk(KERN_INFO "%*c\n", 2 + 2 printk(KERN_WARNING "%*c\n", 2 + 2
* (int) (e->address & (SHADOW_COPY_SIZE - 1)), '^'); * (int) (e->address & (SHADOW_COPY_SIZE - 1)), '^');
break; break;
case KMEMCHECK_ERROR_BUG: case KMEMCHECK_ERROR_BUG: