lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

of/irq: Avoid calling list_first_entry() for empty list

Browse Source 
list_first_entry() expects the list is not empty, we need to check if list is
empty before calling list_first_entry(). Thus use list_first_entry_or_null()
instead of list_first_entry().

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Grant Likely <grant.likely@linaro.org>
This commit is contained in:
Axel Lin
2013-06-23 15:50:07 +08:00
committed by Grant Likely
parent cfd1ee3e37
commit c0cdfaa0a5
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/of/irq.c
View File

@@ -482,8 +482,9 @@ void __init of_irq_init(const struct of_device_id *matches)
} }
/* Get the next pending parent that might have children */ /* Get the next pending parent that might have children */
desc = list_first_entry(&intc_parent_list, typeof(*desc), list); desc = list_first_entry_or_null(&intc_parent_list,
if (list_empty(&intc_parent_list) || !desc) { typeof(*desc), list);
if (!desc) {
pr_err("of_irq_init: children remain, but no parents\n"); pr_err("of_irq_init: children remain, but no parents\n");
break; break;
} }