lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[PATCH] rt2x00: Allways memset memory obtained from skb_push()

Browse Source 
When skb_push() is used we should memset the memory before
usage. This will prevent bugs which could occur when the
data is treated as TX descriptor.

Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
This commit is contained in:
Ivo van Doorn
2007-10-06 14:18:22 +02:00
committed by David S. Miller
parent 37894473fb
commit c22eb87b57
3 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/net/wireless/rt2x00/rt2500usb.c
View File

@@ -1665,6 +1665,8 @@ static int rt2500usb_beacon_update(struct ieee80211_hw *hw,
* First we create the beacon. * First we create the beacon.
*/ */
skb_push(skb, ring->desc_size); skb_push(skb, ring->desc_size);
memset(skb->data, 0, ring->desc_size);
rt2x00lib_write_tx_desc(rt2x00dev, (struct data_desc *)skb->data, rt2x00lib_write_tx_desc(rt2x00dev, (struct data_desc *)skb->data,
(struct ieee80211_hdr *)(skb->data + (struct ieee80211_hdr *)(skb->data +
ring->desc_size), ring->desc_size),

2
drivers/net/wireless/rt2x00/rt61pci.c
View File

@@ -2437,6 +2437,8 @@ static int rt61pci_beacon_update(struct ieee80211_hw *hw, struct sk_buff *skb,
* First we create the beacon. * First we create the beacon.
*/ */
skb_push(skb, TXD_DESC_SIZE); skb_push(skb, TXD_DESC_SIZE);
memset(skb->data, 0, TXD_DESC_SIZE);
rt2x00lib_write_tx_desc(rt2x00dev, (struct data_desc *)skb->data, rt2x00lib_write_tx_desc(rt2x00dev, (struct data_desc *)skb->data,
(struct ieee80211_hdr *)(skb->data + (struct ieee80211_hdr *)(skb->data +
TXD_DESC_SIZE), TXD_DESC_SIZE),

2
drivers/net/wireless/rt2x00/rt73usb.c
View File

@@ -1939,6 +1939,8 @@ static int rt73usb_beacon_update(struct ieee80211_hw *hw, struct sk_buff *skb,
* First we create the beacon. * First we create the beacon.
*/ */
skb_push(skb, TXD_DESC_SIZE); skb_push(skb, TXD_DESC_SIZE);
memset(skb->data, 0, TXD_DESC_SIZE);
rt2x00lib_write_tx_desc(rt2x00dev, (struct data_desc *)skb->data, rt2x00lib_write_tx_desc(rt2x00dev, (struct data_desc *)skb->data,
(struct ieee80211_hdr *)(skb->data + (struct ieee80211_hdr *)(skb->data +
TXD_DESC_SIZE), TXD_DESC_SIZE),