lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

acer-wmi: does not allow negative number set to initial device state

Browse Source 
The driver set module parameter value: mailled, threeg and brightness
to BIOS by evaluate wmi method when driver was initialed. The default
values for those parameters are -1, so, that will be better don't set
negative value to BIOS.

Cc: Carlos Corbacho <carlos@strangeworlds.co.uk>
Cc: Matthew Garrett <mjg@redhat.com>
Cc: Dmitry Torokhov <dtor@mail.ru>
Cc: Corentin Chary <corentincj@iksaif.net>
Signed-off-by: Lee, Chun-Yi <jlee@novell.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
This commit is contained in:
Lee, Chun-Yi
2011-04-15 18:42:47 +08:00
committed by Matthew Garrett
parent bb3ce20204
commit c2647b5e99
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/platform/x86/acer-wmi.c
View File

@@ -961,10 +961,12 @@ static void __init acer_commandline_init(void)
* These will all fail silently if the value given is invalid, or the * These will all fail silently if the value given is invalid, or the
* capability isn't available on the given interface * capability isn't available on the given interface
*/ */
set_u32(mailled, ACER_CAP_MAILLED); if (mailled >= 0)
if (!has_type_aa) set_u32(mailled, ACER_CAP_MAILLED);
if (!has_type_aa && threeg >= 0)
set_u32(threeg, ACER_CAP_THREEG); set_u32(threeg, ACER_CAP_THREEG);
set_u32(brightness, ACER_CAP_BRIGHTNESS); if (brightness >= 0)
set_u32(brightness, ACER_CAP_BRIGHTNESS);
} }
/* /*