lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

tracing, alpha: undefined reference to `save_stack_trace'

Browse Source 
Impact: build fix on !stacktrace architectures

only select STACKTRACE on architectures that have STACKTRACE_SUPPORT

... since we also need to ifdef out the guts of ftrace_trace_stack().
We also want to disallow setting TRACE_ITER_STACKTRACE in trace_flags
on such configs, but that can wait.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Acked-by: Steven Rostedt <srostedt@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
Al Viro
2008-10-31 19:50:41 +00:00
committed by Ingo Molnar
parent 45beca08dd
commit c2c8052946
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
kernel/trace/Kconfig
View File

@@ -25,7 +25,7 @@ config TRACING
bool bool
select DEBUG_FS select DEBUG_FS
select RING_BUFFER select RING_BUFFER
select STACKTRACE select STACKTRACE if STACKTRACE_SUPPORT
select TRACEPOINTS select TRACEPOINTS
select NOP_TRACER select NOP_TRACER

2
kernel/trace/trace.c
View File

@@ -705,6 +705,7 @@ static void ftrace_trace_stack(struct trace_array *tr,
unsigned long flags, unsigned long flags,
int skip, int pc) int skip, int pc)
{ {
#ifdef CONFIG_STACKTRACE
struct ring_buffer_event *event; struct ring_buffer_event *event;
struct stack_entry *entry; struct stack_entry *entry;
struct stack_trace trace; struct stack_trace trace;
@@ -730,6 +731,7 @@ static void ftrace_trace_stack(struct trace_array *tr,
save_stack_trace(&trace); save_stack_trace(&trace);
ring_buffer_unlock_commit(tr->buffer, event, irq_flags); ring_buffer_unlock_commit(tr->buffer, event, irq_flags);
#endif
} }
void __trace_stack(struct trace_array *tr, void __trace_stack(struct trace_array *tr,