lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

[PATCH] PCI: Reduce nr of ptr derefs in drivers/pci/hotplug/pciehprm_acpi.c

Browse Source 
Here's a small patch to reduce the nr. of pointer dereferences in
drivers/pci/hotplug/pciehprm_acpi.c

Benefits:
 - micro speed optimization due to fewer pointer derefs
 - generated code is slightly smaller
 - better readability

Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Jesper Juhl
2005-12-11 06:43:09 +01:00
committed by Greg Kroah-Hartman
parent f5c99dfc11
commit c2dea65530
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/pci/hotplug/pciehprm_acpi.c
View File

@@ -174,7 +174,9 @@ int pciehp_get_hp_hw_control_from_firmware(struct pci_dev *dev)
acpi_status status; acpi_status status;
acpi_handle chandle, handle = DEVICE_ACPI_HANDLE(&(dev->dev)); acpi_handle chandle, handle = DEVICE_ACPI_HANDLE(&(dev->dev));
struct pci_dev *pdev = dev; struct pci_dev *pdev = dev;
struct pci_bus *parent;
u8 *path_name; u8 *path_name;
/* /*
* Per PCI firmware specification, we should run the ACPI _OSC * Per PCI firmware specification, we should run the ACPI _OSC
* method to get control of hotplug hardware before using it. * method to get control of hotplug hardware before using it.
@@ -190,17 +192,18 @@ int pciehp_get_hp_hw_control_from_firmware(struct pci_dev *dev)
*/ */
if (!pdev || !pdev->bus->parent) if (!pdev || !pdev->bus->parent)
break; break;
parent = pdev->bus->parent;
dbg("Could not find %s in acpi namespace, trying parent\n", dbg("Could not find %s in acpi namespace, trying parent\n",
pci_name(pdev)); pci_name(pdev));
if (!pdev->bus->parent->self) if (!parent->self)
/* Parent must be a host bridge */ /* Parent must be a host bridge */
handle = acpi_get_pci_rootbridge_handle( handle = acpi_get_pci_rootbridge_handle(
pci_domain_nr(pdev->bus->parent), pci_domain_nr(parent),
pdev->bus->parent->number); parent->number);
else else
handle = DEVICE_ACPI_HANDLE( handle = DEVICE_ACPI_HANDLE(
&(pdev->bus->parent->self->dev)); &(parent->self->dev));
pdev = pdev->bus->parent->self; pdev = parent->self;
} }
while (handle) { while (handle) {