lk/linux-kernel-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

perf stat: Micro-optimize the code: memcpy is only required if no event is selected and !null_run

Browse Source 
Set attrs and nr_counters if no event is selected and !null_run.

Setting of attrs should depend on number of counters,
so we need to memcpy only for sizeof(default_attrs)

Also set nr_counters as ARRAY_SIZE(default_attrs) in place of
hardcoded value.

Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
LKML-Reference: <1246126749.32198.16.camel@hpdv5.satnam>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
Jaswinder Singh Rajput
2009-06-27 23:49:09 +05:30
committed by Ingo Molnar
parent 6e750a8fc0
commit c3043569dc
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tools/perf/builtin-stat.c
View File

@@ -46,7 +46,7 @@
#include <sys/prctl.h> #include <sys/prctl.h>
#include <math.h> #include <math.h>
static struct perf_counter_attr default_attrs[MAX_COUNTERS] = { static struct perf_counter_attr default_attrs[] = {
{ .type = PERF_TYPE_SOFTWARE, .config = PERF_COUNT_SW_TASK_CLOCK }, { .type = PERF_TYPE_SOFTWARE, .config = PERF_COUNT_SW_TASK_CLOCK },
{ .type = PERF_TYPE_SOFTWARE, .config = PERF_COUNT_SW_CONTEXT_SWITCHES}, { .type = PERF_TYPE_SOFTWARE, .config = PERF_COUNT_SW_CONTEXT_SWITCHES},
@@ -477,16 +477,17 @@ int cmd_stat(int argc, const char **argv, const char *prefix)
{ {
int status; int status;
memcpy(attrs, default_attrs, sizeof(attrs));
argc = parse_options(argc, argv, options, stat_usage, 0); argc = parse_options(argc, argv, options, stat_usage, 0);
if (!argc) if (!argc)
usage_with_options(stat_usage, options); usage_with_options(stat_usage, options);
if (run_count <= 0 || run_count > MAX_RUN) if (run_count <= 0 || run_count > MAX_RUN)
usage_with_options(stat_usage, options); usage_with_options(stat_usage, options);
if (!null_run && !nr_counters) /* Set attrs and nr_counters if no event is selected and !null_run */
nr_counters = 8; if (!null_run && !nr_counters) {
memcpy(attrs, default_attrs, sizeof(default_attrs));
nr_counters = ARRAY_SIZE(default_attrs);
}
nr_cpus = sysconf(_SC_NPROCESSORS_ONLN); nr_cpus = sysconf(_SC_NPROCESSORS_ONLN);
assert(nr_cpus <= MAX_NR_CPUS); assert(nr_cpus <= MAX_NR_CPUS);